Just-Some-Bots / MusicBot

:musical_note: The original MusicBot for Discord (formerly SexualRhinoceros/MusicBot)
https://just-some-bots.github.io/MusicBot/
MIT License
3.09k stars 2.35k forks source link

Optimize play commands #2382

Closed itsTheFae closed 5 months ago

itsTheFae commented 5 months ago

Description

This PR includes a complete overhaul of ytdl information extraction and updates bits that directly interact with extracted info. The primary focus of this PR is to increase speed of the bot when processing playlists, but several changes are included.

A full list of noteworthy changes:

This update does not include complete i18n or entirely consistent UI (embed vs message) content.
That aside, It should be ready for extensive testing.

Related issues (if applicable)

Potentially closes: #2376 #2375 #1587 and #1462

BabyBoySnow commented 5 months ago

EXTENSIVE TESTING PENDING.

BabyBoySnow commented 5 months ago

Using directly from branch, seems to be working well 👍

DestinyofYeet commented 5 months ago

Fine to merge IMO if it works.

itsTheFae commented 5 months ago

I have not seen any total show stoppers while using it myself. If folks are OK with it in this state I'm OK with this being merged whenever.