search

Just-Some-Bots / MusicBot

:musical_note: The original MusicBot for Discord (formerly SexualRhinoceros/MusicBot)
https://just-some-bots.github.io/MusicBot/
MIT License
3.12k stars 2.35k forks source link

[Feature request] Support chiptune modules files. #89

Closed luckcolors closed 8 years ago

luckcolors commented 8 years ago

Hello i just tried you bot and it's amazing it works great. But i would also like it to play chiptune files .xm .mod .it .etc. for more info on chiptunes check https://woolyss.com/chipmusic.php. For supporting the playtrouught of the chiptunes you could use http://lib.openmpt.org/libopenmpt/ from the open mtp tracker. It supports all chitunes formats except some like .sid (c64 commodore) and .ftm(famitracker) which are less common (for complete supported files see http://openmpt.org/features). I hope you can really implement this feature. Thanks in advance :P.

imayhaveborkedit commented 8 years ago

If ffmpeg supports it, the bot supports it. I have nothing to do with it.

imayhaveborkedit commented 8 years ago

It has come to my attention that while the bot doesn't seem to be able to play these, ffmpeg should technically support these. I'll have to figure out why ffmpeg isn't converting them.

Random link with various MODs: http://paul.chattaway.com/clacomp/mods/modlist.html

imayhaveborkedit commented 8 years ago

Ok I figured it out. Turns out ffmpeg just doesn't like the .mp3 extension on the file when youtube_dl downloads it (we just slap .mp3 on everything and usually ffmpeg is fine with it). I'll add this to my todo list. This will actually probably be fixed when I fix how files are managed though.

luckcolors commented 8 years ago

You can probably ease the download by using wget when a direct link to a file is given. Eg. http://example.org/chiptune.xm

imayhaveborkedit commented 8 years ago

It's not a download issue, youtube-dl takes care of that. The issue is that everything gets renamed with an .mp3 extension, regardless of content. Since ffmpeg doesn't like that, it has to be changed for them to work.

imayhaveborkedit commented 8 years ago

This should be fixed now as the bot saved files with their actual extension.