search

Just2good / TFT-Overlay

Overlay for Teamfight Tactics
GNU General Public License v3.0
641 stars 262 forks source link

Update and rename ItemStrings_en-US.xaml to ItemStrings_pl.xaml #100

Closed Jadowity336 closed 5 years ago

Jadowity336 commented 5 years ago

I uptaded all items and champions description in polish language version. I hope you will add it in next patch.

Just2good commented 5 years ago

You cant replace en-US, you have to make a new .xaml file. Also there is already an ItemStrings_PL.xaml so you'll have to go and edit that instead. Feel free to send another pull request with the correct method.

Jadowity336 commented 5 years ago

You cant replace en-US, you have to make a new .xaml file. Also there is already an ItemStrings_PL.xaml so you'll have to go and edit that instead. Feel free to send another pull request with the correct method. Ive been never doing this before. As I see I can do a new file with name "ItemStrings_PL.xaml", but i cant change existing file, bacause it is not mine. If it is ok to just make new file ill send it. Unless I cannot do this that way, i need to know how to do this. Im waiting for responed.

Just2good commented 5 years ago

There is already a PL file which you can edit here https://github.com/Just2good/TFT-Overlay/blob/master/Resource/Localization/ItemStrings_PL.xaml

Jadowity336 commented 5 years ago

I sent the newest version of my changes. I hope everything is alright.