Just2good / TFT-Overlay

Overlay for Teamfight Tactics
GNU General Public License v3.0
641 stars 262 forks source link

Patch 9.17 Update #120

Open jtborn opened 5 years ago

jtborn commented 5 years ago

Hi, I forked your repo and added the latest changes: Added Hextech origin and champions Added Pantheon to Dragon/Guardian Updated items and class origins with the latest patch changes to the ItemStrings_en-US.xaml descriptions. Code builds, adjusted some of the row sizes so that the text would all fit.

jtborn commented 5 years ago

One note, I did not update the version #, so you'll have to update that to whatever number you want for the auto-updater to work.

sunuanxiaopy commented 5 years ago

Hi, I think just2good is not updated, can you convert it into. Convert to.EXE format ? Thank you very much. Look forward to your next update.

jtborn commented 5 years ago

Hi sunuanxiaopy, I was hoping J2G would just merge in my updates but it doesn't look like they're going to so when I get home from work tonight I will upload the .exe to my repo and change my readme file to point to it and comment again here so you get a notification.

sunuanxiaopy commented 5 years ago

thank u so much❤️

在 2019年9月9日,23:24,jtborn notifications@github.com 写道:

Hi sunuanxiaopy, I was hoping J2G would just merge in my updates but it doesn't look like they're going to so when I get home from work tonight I will upload the .exe to my repo and change my readme file to point to it and comment again here so you get a notification.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

jtborn commented 5 years ago

I've published my release here: https://github.com/jtborn/TFT-Overlay/releases/tag/V2.0.6 It works the same way. When the new patch drops I will update the relevant items and update the version number so the auto-updater feature will still work and it'll pull the newest update for you automatically. Let me know if you have any issues! Thanks.

sunuanxiaopy commented 5 years ago

That’s so sweet and convenient,thank u

在 2019年9月10日,14:42,jtborn notifications@github.com 写道:

It works the same way. When the new patch drops I will update the relevant items and update the version number so the auto-updater feature will still work and it'll pull the newest update for you automatically.

Tobu76 commented 5 years ago

Hi,jtborn.Could you publish the latest 9.18 version update?You know ,there are plenty of new items .Looking for your update and thank u very much!

jtborn commented 5 years ago

Hey Tobu76, sorry I've been at work. I pushed 9.18 to my branch. It's V2.0.8 let me know if the auto-updater works. I added Neeko's Help (I'll crop it into a circle later, just didn't have the template that J2G was using so I have to create my own in photoshop) and the patch changes but the Sparring Gloves items don't drop until 9.19 right? I haven't played yet today just going off patch notes.

jingfan2646 commented 5 years ago

Hello, I am a Chinese players, help you to translate the new Chinese patch

jtborn commented 5 years ago

Hi jingfan, please do. I've added the new items in English to the zh-CN.xaml localization file to make it easier for you to translate directly from that file without having to merge in my US.xaml code file.

jingfan2646 commented 5 years ago

Here have a new Chinese translation, please download https://github.com/jingfan2646/TFT-Overlay/tree/master/Resource/Localization

jtborn commented 5 years ago

Thanks, I will be able to merge it later tonight when I get home.

jingfan2646 commented 5 years ago

Hello, I found several translation errors, has now been repaired, I hope you can repair

jtborn commented 5 years ago

Hi, I'll be able to fix it when I'm home from work in about 8 hours. If you can submit a pull request to my branch it makes it easier to merge for future fixes.

Edit: I've now pushed the release with your latest fixes. I didn't merge in the Yordle 9 buff as that is still unconfirmed (I'll wait for the official 9.19 Patch Notes) and it looks like you changed Warmogs to 8% but looking at the Garena patch notes it looks like it should be 6%. Let me know if you think that's wrong. I know it's 6% on US servers.