JustAHuman-xD / SlimefunEssentials

A client sided mod to enhance Slimefun
MIT License
19 stars 11 forks source link

Add Support for Just Enough Calculation #23

Closed 54M44R closed 6 months ago

54M44R commented 7 months ago

Just Enough Calculation is a mod that assists in calculating the materials needed for a recipe. It is very useful when working with large and / or complex recipes.

The mod also supports placeholders, which are meant as a way to signify more abstract things, such as a multiblock structure. Say you have a multiblock X, which requires blocks A, B, and C. You can create a placeholder, called X, and use it as the "output" portion of a recipe. In essence, this also assists with builds as well.

Currently though, almost all items from SlimefunEssentials are being registered as Placeholders.

Example with recipe for 5 reinforced ingots:

image

With their names being:

image

The naming scheme suggests its related to the SlimefunItemStack() method. For clarity, they are not all considered Damascus Steel

It seems that items without a registered recipe function normally:

image

The electric smeltery does not have a registered recipe from SlimefunEssentials, and thus is not considered a Placeholder by JEC.

I am unsure as to what leads JEC to assume SlimefunEssentials items as Placeholder items. Assuming the cause is identified and fixed, this would make SlimefunEssentials and JEC compatiable.

JustAHuman-xD commented 7 months ago

I can add it to my to do list, no guarantee as to when I'll look into it

JustAHuman-xD commented 6 months ago

@54M44R could you send the logs too?

54M44R commented 6 months ago

This comment is to serve as a record that commit #037908e has fully implemented support for JEC.

image