JustATac0 / GLaDOS

Code for the discord bot from this video >>> https://www.youtube.com/watch?v=EIUqm8k1VOY&lc=UgyNN_NTW5IvWNbMKYZ4AaABAg
Creative Commons Zero v1.0 Universal
15 stars 9 forks source link

Unsynced Music #1

Open Def-Try opened 2 years ago

Def-Try commented 2 years ago

Hello! I wanted this bot on my server, so I downloaded source code, still alive mp3 and put token. But there is a problem: music is unsynced. Down here a stillalive.mp3 file(rename .zip to .mp3). Hope you can help me(or upload your version of stillalive.mp3, if problem with music) stillalive.zip

JustATac0 commented 2 years ago

Hi there! this version of the .mp3 should work :) Let me know if you're still having trouble and I'll mess around some more when I've got time! stillalivemp3.zip

kneeecaps commented 2 years ago

Just one thing I would like to highlight, but the timings in the bot are largely dependent on your internet connection. For example, faster internet connections need more delay than slower connections. I mainly noticed this because when I was adding the code for the bot to support "Want You Gone" too, my internet was being very dodgy and I noticed that the exact same code was getting inconsistent results. This may just be something that if you want it done right, you have to go and edit the timings yourself.

kneeecaps commented 2 years ago

One other thing I would like to mention on the timing, I noticed that the code was mostly right for me if I added .5 seconds onto each time. Maybe just change the code so the wait time is something like ORIGINALTIME - difference, with an example being 5 - x. Then you can change the value of x to modify all the values by either adding or subtracting a value. If you then change x by adding or subtracting .1 each time while you are getting closer to having the song and text synchronized, you can get fairly close.

I don't think there really is anything we can do to help fix the sync issues for everyone, maybe someone could write an algorithm that modifies the time based off ping or something. Anyway, what I listed above is a bit of a fix for anyone that REALLY wants to use the bot