JustArchiNET / ASF-ui

The official web interface for ASF
Apache License 2.0
271 stars 38 forks source link

Make it clearer that user filtered visible bots #1564

Closed JustArchi closed 2 years ago

JustArchi commented 2 years ago

Checklist

Enhancement purpose

obraz

Solution

I imagine we should grey-out the unselected options instead, maybe leaving the current green highlight for additional visibility, but that alone is not sufficient.

Why currently available solutions are not sufficient?

It's not the first time somebody is confused what happened.

Can you help us with this enhancement idea?

Somehow, I can test and offer feedback, but can't code

Additional info

No response

JustArchi commented 2 years ago

obraz

This should also be addressed, we can't set other squares to 0 just because bots are not visible.

MrBurrBurr commented 2 years ago

Thank you for creating this issue. I also thought about a solution when I saw DetectiveFingerling's post but you were faster :p

I would suggest the following solution: Once at least one filter is active we will show a little info where the bots usually are shown:

You have a filter active, not all of your bots are currently being shown.
Click here to disable all filters.

I think this is a nice solution, let me know what you think.

And regarding:

This should also be addressed, we can't set other squares to 0 just because bots are not visible.

We are not doing this in the first place. You can try it for yourself and verify.

JustArchi commented 2 years ago

I'm not an expert in frontend, whatever you believe is right I support you in that :slightly_smiling_face: