Make eye button state coincide with current password visibility state

[Botan626]

Checklist

• [X] I read and understood ASF-ui's Contributing Guidelines
• [X] I also read FAQ
• [X] My idea doesn't duplicate existing ASF-ui functionality described on the wiki
• [X] I believe that my idea falls into ASF-ui's scope and should be offered as part of ASF-ui built-in functionality
• [X] This is not ASF suggestion

Enhancement purpose

Currently they mismatch each other, which can be misleading and confusing. If eye is crossed, password should be hidden, and vice versa, shouldn't it?

[Abrynos]

You can look at it the other way and interpret the icon as the "action to do" or "target state after the click"... so the crossed out eye means "hide" while the normal eye mans "show".

[Botan626]

You can look at it the other way and interpret the icon as the "action to do" or "target state after the click"... so the crossed out eye means "hide" while the normal eye mans "show".

Or I can continue to look at it the other way and treat this eye as a switch, which should correctly indicate its current state.

[MrBurrBurr]

There is no "correct" here. Both scenarios are valid as long as they are implemented consistently. Look at the encrypt/hash function where the eye icon is normal when the password is masked (not visible) and switches to a crossed-out eye icon when the password is visible.

This approach indicates the action that’s performed when you press the icon.