JustArchiNET / ASF-ui

The official web interface for ASF
Apache License 2.0
263 stars 38 forks source link

Fix executing commands on Android chromium browsers #1681

Closed oubeichen closed 3 months ago

oubeichen commented 3 months ago

Description

Fixes https://github.com/JustArchiNET/ASF-ui/issues/1590

In Chromium-based browsers on Android, when there are multiple input fields and the enterkeyhint attribute is not set, pressing the Enter key on the virtual keyboard will automatically switch to the next input field.

This behavior contradicts our expectation of inserting a line break.

Therefore, we need to manually set the enterkeyhint attribute to enter in the input fields.

Screenshots

None, but behaviors can be tested at https://codepen.io/Beichen-Ou/pen/zYQzLNz

Additional information

Checklist

JLCareglio commented 3 months ago

🙌 Thanks for this contribution, I hope they accept it soon 😄

MrBurrBurr commented 3 months ago

Thank you for your PR 💪

I do not have a android device so I can't test it myself. @zynowhere maybe you could test if it resolves your issue? Or maybe @Abrynos has some time in the near future?

Also, do we have to set enterkeyhint attribute on the autocomplete input aswell? Wouldn't it be enough with just the main input?

oubeichen commented 3 months ago

Thank you for your PR 💪

I do not have a android device so I can't test it myself. @zynowhere maybe you could test if it resolves your issue? Or maybe @Abrynos has some time in the near future?

Also, do we have to set enterkeyhint attribute on the autocomplete input aswell? Wouldn't it be enough with just the main input?

You are right, simply modifying the attribute of the main input is sufficient to solve the problem. I have already rebased the change. Additionally, setting the autocomplete input to disabled can achieve a similar effect. It's up to you to decide. Also, attached is the mobile test recording.

https://github.com/JustArchiNET/ASF-ui/assets/2402901/b76e7aa4-f354-4a7c-9260-c8a56ee17d23

https://github.com/JustArchiNET/ASF-ui/assets/2402901/caf580f9-c05c-4057-adc7-047a6b94310b

MrBurrBurr commented 3 months ago

Thank you for your contribution!