JustArchi
commented
4 years ago Take a look at what happening with 32X5I-A9H6A-N734D key - it was redeemed twice on multiple bots, this should not happen.
It wasn't, you have no status that determines the key is used, only certain statuses determine that, e.g. invalid key, duplicate key or redeemed key, none of those is included in your log, so ASF properly tries to redeem the same key on different bots, this is exactly how forwarding + distribution works, as per the wiki.
Enabling both Forwarding and Distributing will add distributing feature on top of forwarding one, which makes ASF trying to redeem one key on all bots firstly (forwarding) before moving to the next one (distributing).
This includes a possibility of running into the same bots, because the distribution went from bot6 and not bot3. ASF had to finish the queue alphabetically first before going back to the beginning and trying again.
Even with the first 6FE08-A24FH-N0QWN key you can notice this behaviour - ASF tries that key until it stops with Fail/DuplicateActivationCode, exactly because only then we can be sure that it's truly used. This is no different than 32X5I-A9H6A-N734D approach, except that we could determine first key to be already used, while we couldn't do the same with the second one. And it's not guaranteed that ASF can determine which bots to try based on the package alone, some packages activate the same apps and in this case Steam won't allow to redeem them, while we have no capability to determine this in advance.
Nothing you described above is a bug.
Rudokhvist
Bug report
Description
I have 9 bots running, one of them is has both
ForwardingandDistributingenabled inRedeemingPreferences. I send a batch of keys to this bot, and under some condition it tries to redeem same key on same bot twice. Below is a copy&paste of chat with this issue (I replaced bot names for paranoia reasons, keys are all used, so it's safe to post them, bot8 = my main account, bot3 = account I'm chatting with)::exclamation::exclamation::exclamation:Take a look at what happening with
32X5I-A9H6A-N734Dkey - it was redeemed twice on multiple bots, this should not happen.Expected behavior
There should be only one attempt to redeem one particular key on one particular bot.
Current behavior
There were two attempts to redeem one particular key on one particular bot
Steps to reproduce
I was unable yet to reliably reproduce it with small amount of keys and bots, but I tried to redeem the same batch of keys as above multiple times (with intervals to allow
RateLimitedbots to become available again) and got the same result every time, so it's reproducible at least in given environment.Full log.txt recorded during reproducing the problem
Global ASF.json config (if using one)
BotName.json config of all affected bot instances (if more than one)