Closed JABirchall closed 1 year ago
Thanks for report.
Unfortunately, there is nothing that can be done about requests failing and Steam being unstable. We've already added trade check period property linked above to fight with this, you can tweak that property to hopefully react to missed trades earlier than configured default, but other than that, your options are limited.
In particular, ASF can only try at given point of time to react to (accept) the trade offer. If that fails due to any reason, most commonly, Steam being unstable/having difficulties, your trade offer won't be accepted, ASF already tries total of 5 times at any given point of time to deal with this. If those 5 tries fail, the next attempt happens at next trades check event, which is normally triggered with the next trade offer, but trade check period can make it happen earlier, this one you can configure.
Since there is nothing I believe that can further improved in this regard, I'll close this issue. Thanks anyway!
Checklist
ASF version
Latest stable release
ASF variant
win-x64
Bug description
When archi is accepting/declining a trade based on tradematcher rules it sometimes doesnt despit logging it has done so. It doesnt notice it didnt accept/decline the trade and doesnt notice the trade is still open to retry. This then leads to the trade being cancelled if sent by another ArchiSteamBot) if its sent by a user it can be manually accepted/declined.
Expected behavior
Expected to Accept or decline a trade. If unsuccesful retry. If trade is still open retry.
Actual behavior
If it fails to accept/decline a trade it ignores the trade and leaves it open for the user to handle.
Steps to reproduce
I dont know, its random.
Possible reason/solution
Unknown
Can you help us with this bug report?
Somehow, I can test and offer feedback, but can't code
Full log.txt recorded during reproducing the problem
Global ASF.json config file
BotName.json config of all affected bot instances
Additional info
No response