Option to choose which plugins are enabled on which bots.

EvE-Player commented 11 months ago

Checklist

[X] I read and understood ASF's Contributing guidelines
[X] I also read Setting-up and FAQ, I don't need help, this is an enhancement idea
[X] My idea doesn't duplicate existing ASF functionality described on the wiki
[X] I believe that my idea falls into ASF's scope and should be offered as part of ASF built-in functionality
[X] My idea doesn't violate the Steam Subscriber Agreement
[X] My idea doesn't violate the Steam Online Conduct
[X] This is not ASF-ui suggestion

Enhancement purpose

ASF Offers the option to have plugins, some of which are listed on the Wiki so my proposal is: Would you be willing to add a config option to enable or disable plugins on specific bots please?

For example, I have two bots I want to use "generic plugin" on, another two bots I want to use "generic plugin2" on and finally six bots I don't want to use either plugin on, just the normal plugins.

Solution

EnabledPlugins: "Plugin1, Plugin2, Plugin3" if not set enable all by default

Or something like this?

Why currently available solutions are not sufficient?

As far as I can tell there isn't an option for this anywhere?

It can be done by running multiple instances and this way of doing it is definitely better than nothing.

Can you help us with this enhancement idea?

No, I don't have time, skills or willings for any of that

Additional info

I realise this could be implemented into the plugins themselves however it would seem more logical at least to me to add it as a config option in the base program as Plugins are officially supported?

Whichever way you decide, I would like to send my appreciation for such a useful program, to Archi and all those who contribute in ways most of us can't!

Anyway, thank you for taking the time to read this and I understand if it's not something you would want to implement.

Abrynos commented 11 months ago

In my opinion this is more of a plugin issue than an ASF issue. Your plugins developer should provide you with the possibility of per-bot configuration, which is already supported from ASF side of things.

EvE-Player commented 11 months ago

In my opinion this is more of a plugin issue than an ASF issue. Your plugins developer should provide you with the possibility of per-bot configuration, which is already supported from ASF side of things.

I had guessed that may be the answer but thought it couldn't hurt to ask! Thanks for the response.

JustArchi commented 11 months ago

While this in theory could be possible due to us skipping callbacks related to given bots, it's physically impossible for ASF to put any hard barrier that would disallow plugins to touch specific bots. You need to understand that you're loading arbitrary code inside ASF process - at this point any kind of "blocks" are invalid since plugin has full control over ASF process and it can do everything inside of it, which is why it's explicitly stated on the wiki.

As such, this enhancement is simply not going to happen. Instead, the proper thing to do is to add appropiate code inside the plugin itself, so it can limit its own surface only to given bots scope. If you're unable to do that due to any reason, you need to launch several ASF processes as only that can physically block your loaded plugins from reaching surface it should not have access to - best if supported with additional OS-specific barriers, such as being launched by different users on Linux machine.

EvE-Player commented 11 months ago

Okay, thank you both for your time and responses!

JustArchiNET / ArchiSteamFarm