Use gender neutral language

JustArchiNET / ArchiSteamFarm

C# application with primary purpose of farming Steam cards from multiple accounts simultaneously.

Apache License 2.0

11.09k stars 1.04k forks source link

Use gender neutral language #3057

Closed leetfin closed 10 months ago

leetfin commented 10 months ago

Checklist

[x] I read and understood the Contributing Guidelines.
[x] This is not a duplicate of an existing merge request.
[x] I believe this falls into the scope of the project and should be part of the built-in functionality.
[x] My code follows the code style of this project.
[x] I have added tests to cover my changes, wherever they are necessary.
[x] All new and existing tests pass.

Changes

Use gender-neutral language where possible.

Additional info

Fixes random typo as well

leetfin commented 10 months ago

code-quality check appears to have failed for environment reasons and not due to the proposed changes.

Abrynos commented 10 months ago

Is this a last-ditch low-effort PR to get into hacktoberfest? Because apparently you didn't look at localized strings shown to all users but only at comments, which MUCH less people read (if at all).

nolddor commented 10 months ago

Unless you ~~fix~~ target localized strings shown to ASF users on console and command outputs, this PR makes 0 sense to me.

leetfin commented 10 months ago

I exclude localized strings by default as they are often handled by other tools and are not something to be manually modified. I will check those now.

Rudokhvist commented 10 months ago

Localized strings should not be fixed indeed, and I don't see anything that requires fixes in Strings.resx to begin with (but I didn't check thoroughly, just used search and found nothing). So looks good to me.

JustArchi commented 10 months ago

Thanks! :trophy: