JustArchiNET / ArchiSteamFarm

C# application with primary purpose of farming Steam cards from multiple accounts simultaneously.
Apache License 2.0
11.06k stars 1.04k forks source link

Use generic ProducesResponseTypeAttribute instead of typeof(...) #3074

Closed Abrynos closed 9 months ago

Abrynos commented 9 months ago

Checklist

Changes

The code now uses the generic version of ProducesResponseType on the controller methods in the IPC server to get rid of the overly explicit typeof(...) we've previously used.

New functionality

None

Changed functionality

None

Removed functionality

None

Additional info

Thank you for considering the inclusion of this merge request.

JustArchi commented 9 months ago

Did you check if this works with swagger, that is, correct structures are reported in swagger json, which is pretty much the only consumer of those attributes?

Easiest to download swagger.json generated before and after this change, diff them and see if they're the same.

Abrynos commented 9 months ago

Did you check if this works with swagger

Yeah. Previously I had only checked swagger UI, but for the sake of the argument I just went and did a diff on the JSON structure as well and there was zero changes.

JustArchi commented 9 months ago

Great, this is golden then, thanks a lot! :trophy: