ArchiSteamFarm is unable to generate Web API Keys anymore

nolddor commented 9 months ago

Checklist

[X] I read and understood ASF's Contributing guidelines
[X] I also read Setting-up and FAQ, I don't need help, this is a bug report
[X] I don't own more than 10 accounts in total
[X] I'm not using custom plugins
[X] This is not a question
[X] This is not a technical issue
[X] This is not ASF-ui problem

ASF version

Latest stable release

ASF variant

linux-x64

Bug description

It looks like today Valve roll out a new change so in order to create a Web API Key, a mobile confirmation is needed. Refers to https://twitter.com/zerguet/status/1730531743575208386

Expected behavior

ArchiSteamFarm must be able to auto-generate a Web API Key when not present as it is a mandatory requirement for ASF to query some internal APIs

Actual behavior

An error is thrown on the logs:

2023-12-01 18:59:44|ArchiSteamFarm-728438|ERROR|BotName|ResolveApiKey() Received unknown value for State, please report this: NotRegisteredYet

Steps to reproduce

Navigate to https://steamcommunity.com/dev/apikey en delete any existing Web API (if any)
Start up ArchiSteamFarm from scratch or do a !restart
You will see the error within the logs.

Possible reason/solution

A recent change at Valve side as per https://twitter.com/zerguet/status/1730531743575208386 that requires source code rework to auto-confirm the Web API Key generation, refers to: https://github.com/JustArchiNET/ArchiSteamFarm/blob/9699686da5b3d3f6fca131b1b22be4e75525bb99/ArchiSteamFarm/Steam/Integration/ArchiWebHandler.cs#L2595

Can you help us with this bug report?

Somehow, I can test and offer feedback, but can't code

Full log.txt recorded during reproducing the problem

N/A

Global ASF.json config file

N/A

BotName.json config of all affected bot instances

N/A

Additional info

JustArchi commented 9 months ago

Thanks for report, I've addressed this with a warning and automatic registration (if possible) :trophy:

JustArchi commented 8 months ago

Update: follow-up on this issue includes complete API keys removal, I'm leaving this note mainly for people digging into the issue wondering about current state of API keys in ASF.

https://github.com/JustArchiNET/ArchiSteamFarm/commit/27f965d4af4e54961e33de18f41636387d0f3580 https://github.com/JustArchiNET/ArchiSteamFarm/commit/fa74d98879994c419b2de2ac220f16f175fef749

JustArchiNET / ArchiSteamFarm