Research into private games

JustArchi commented 8 months ago

Checklist

[X] I read and understood ASF's Contributing guidelines
[X] I also read Setting-up and FAQ, I don't need help, this is an enhancement idea
[X] This is not a duplicate of an existing issue
[X] My idea doesn't duplicate existing ASF functionality described on the wiki
[X] I believe that my idea falls into ASF's scope and should be offered as part of ASF built-in functionality
[X] My idea doesn't violate the Steam Subscriber Agreement
[X] My idea doesn't violate the Steam Online Conduct
[X] This is not ASF-ui suggestion

Enhancement purpose

https://help.steampowered.com/faqs/view/1150-C06F-4D62-4966

Solution

Find out proto updates and do RE with NH2 to see how exactly Steam provides client with that info, if at all -> IDeviceAuthService.GetExcludedGamesInLibrary (thanks @xPaw)
Add logic to ASF to do the same and skip games marked as such

Why currently available solutions are not sufficient?

Steam doesn't remove games automatically from badge pages, which means ASF idling process will be stuck upon finding them.

Can you help us with this enhancement idea?

Yes, I can code the solution myself and send a pull request

Additional info

No response

Abrynos commented 8 months ago

Given following quote I understand that we want to skip such game.

You will not receive Steam Trading Cards for the game while it is marked as Private

But out of curiosity I have to ask: Do we know what happens if we pass the necessary play-time (by a multitude of the necessary to get cards for example) while it is private and then suddenly set it public just for one minute? Could this be a potential "attack vector" at the problem?

JustArchi commented 8 months ago

It's out of the scope at this stage to do anything else than ignoring those games, but we might consider other options in the future, e.g. automatically hiding farmed games.

Ekibunnel commented 8 months ago

But out of curiosity I have to ask: Do we know what happens if we pass the necessary play-time (by a multitude of the necessary to get cards for example) while it is private and then suddenly set it public just for one minute? Could this be a potential "attack vector" at the problem?

I've tested just that : Got a game as private, ASF got stuck on it for 61 hours, unprivate the game, no instant drop and now the cards start to drop one by one at a normal rate.

JustArchi commented 7 months ago

Update after research, the endpoints we're after are https://github.com/SteamDatabase/Protobufs/blob/0e2d811e5641841908adb1a440994324b3130699/webui/service_accountprivateapps.proto#L14

Requires SK2 bump

JustArchiNET / ArchiSteamFarm