JustArchiNET / ArchiSteamFarm

C# application with primary purpose of farming Steam cards from multiple accounts simultaneously.

Apache License 2.0

11.15k stars 1.04k forks source link

Closes #3061 #3145

Closed JustArchi closed 7 months ago

JustArchi commented 7 months ago

This is proof of concept for now, extensive testing and fixes are required before merging.

TODO:

[x] Investigate how we can make [JsonDisallowNull] work
[x] Test edge cases: [JsonExtensionData], JsonNode and JsonElement places
[x] Do extensive testing otherwise

It seems to work good enough though to consider this for merging in the future.

Closes #3061

github-actions[bot] commented 7 months ago

Qodana for .NET

1 new problem were found

Inspection name	Severity	Problems
`RoslynAnalyzers Do not catch general exception types`	◽️ Notice	1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked ☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [qodana-support@jetbrains.com](mailto:qodana-support@jetbrains.com) - Or via our issue tracker: https://jb.gg/qodana-issue - Or share your feedback: https://jb.gg/qodana-discussions

JustArchi commented 7 months ago

@Rudokhvist @ezhevita @Abrynos this is now ready for review and/or testing if somebody wanted to.

Doc will arrive later, but copy-pasting my quick overview from Discord.

obraz

nolddor commented 7 months ago

Thanks for all the effort you put on closing this one! <3