ValidateGamesToRedeemInBackground() name is invalid!

JakeyPrime commented 7 months ago

Checklist

[X] I read and understood ASF's Contributing guidelines
[X] I also read Setting-up and FAQ, I don't need help, this is a bug report
[X] This is not a duplicate of an existing issue
[X] I don't own more than 10 accounts in total
[X] I'm not using custom plugins
[X] This is not a question
[X] This is not a technical issue
[X] This is not ASF-ui problem

ASF version

Latest stable release

ASF variant

docker-linux/amd64

Bug description

Redeeming a key both with no name or with a provided name via the UI returns this error in the log when clicking confirm on the actual "key redeem overview" page.

Expected behavior

Key is redeemed in the background.

Actual behavior

Confirm button briefly shows a loading state, then reverts to confirm, bug title error appears in log when this happens

Steps to reproduce

Put a key to redeem in BGR
Push confirmation button
See preview of what should happen
Push confirm
Error appears in log

Possible reason/solution

I thought it was an issue with not providing a name for the key in a new version, but then when trying with a name, it also produces the same error.

Can you help us with this bug report?

Somehow, I can test and offer feedback, but can't code

Full log.txt recorded during reproducing the problem

2024-02-26 16:31:46|ArchiSteamFarm-1261774|INFO|Zira|Connect() Connecting...
2024-02-26 16:31:47|ArchiSteamFarm-1261774|INFO|Zira|OnConnected() Connected to Steam!
2024-02-26 16:31:47|ArchiSteamFarm-1261774|INFO|Zira|OnConnected() Logging in...
2024-02-26 16:31:47|ArchiSteamFarm-1261774|INFO|Zira|OnLoggedOn() Successfully logged on as 76561198057477719/JakeyPrime.
2024-02-26 16:31:47|ArchiSteamFarm-1261774|INFO|Zira|Init() Success!
2024-02-26 16:31:48|ArchiSteamFarm-1261774|INFO|Zira|IsAnythingToFarm() Checking first badge page...
2024-02-26 16:31:48|ArchiSteamFarm-1261774|INFO|Zira|CheckOccupationStatus() Account is currently being used: ASF will resume farming when it's free...
2024-02-26 16:31:49|ArchiSteamFarm-1261774|INFO|Zira|IsAnythingToFarm() Checking other badge pages...
2024-02-26 16:31:50|ArchiSteamFarm-1261774|INFO|Zira|StartFarming() We don't have anything to farm on this account!
2024-02-26 16:32:48|ArchiSteamFarm-1261774|INFO|Zira|Refresh() Retrieving a total of 109 app access tokens...
2024-02-26 16:32:48|ArchiSteamFarm-1261774|INFO|Zira|Refresh() Retrieving 109 app access tokens...
2024-02-26 16:32:48|ArchiSteamFarm-1261774|INFO|Zira|Refresh() Finished retrieving 109 app access tokens.
2024-02-26 16:32:48|ArchiSteamFarm-1261774|INFO|Zira|Refresh() Finished retrieving a total of 109 app access tokens.
2024-02-26 16:32:48|ArchiSteamFarm-1261774|INFO|Zira|Refresh() Retrieving all depots for a total of 109 apps...
2024-02-26 16:32:48|ArchiSteamFarm-1261774|INFO|Zira|Refresh() Retrieving 109 app infos...
2024-02-26 16:32:48|ArchiSteamFarm-1261774|INFO|Zira|Refresh() Finished retrieving 109 app infos.
2024-02-26 16:33:09|ArchiSteamFarm-1261774|INFO|Zira|Refresh() Successfully retrieved 28 out of 28 depot keys.
2024-02-26 16:33:09|ArchiSteamFarm-1261774|INFO|Zira|Refresh() Finished retrieving all depot keys for a total of 109 apps.
2024-02-26 16:34:38|ArchiSteamFarm-1261774|INFO|Virt|CheckOccupationStatus() Account is no longer occupied: farming process resumed!
2024-02-26 17:03:11|ArchiSteamFarm-1261774|WARN|HepBot|OnPersonaState() Failed due to error: IsEligibleForListing: False
2024-02-26 17:08:55|ArchiSteamFarm-1261774|INFO|Ken|CheckOccupationStatus() Account is no longer occupied: farming process resumed!
2024-02-26 17:17:58|ArchiSteamFarm-1261774|WARN|ASF|ValidateGamesToRedeemInBackground() name is invalid!
2024-02-26 17:19:59|ArchiSteamFarm-1261774|WARN|ASF|ValidateGamesToRedeemInBackground() name is invalid!
2024-02-26 17:20:00|ArchiSteamFarm-1261774|WARN|ASF|ValidateGamesToRedeemInBackground() name is invalid!
2024-02-26 17:20:00|ArchiSteamFarm-1261774|WARN|ASF|ValidateGamesToRedeemInBackground() name is invalid!
2024-02-26 17:20:17|ArchiSteamFarm-1261774|WARN|ASF|ValidateGamesToRedeemInBackground() name is invalid!

Global ASF.json config file

{
  "WebProxy": null,
  "AutoRestart": true,
  "Blacklist": [],
  "CommandPrefix": "!",
  "ConfirmationsLimiterDelay": 10,
  "ConnectionTimeout": 90,
  "CurrentCulture": null,
  "Debug": false,
  "DefaultBot": null,
  "FarmingDelay": 15,
  "FilterBadBots": true,
  "GiftsLimiterDelay": 1,
  "Headless": true,
  "IdleFarmingPeriod": 8,
  "InventoryLimiterDelay": 4,
  "IPC": true,
  "IPCPasswordFormat": 0,
  "LicenseID": null,
  "LoginLimiterDelay": 10,
  "MaxFarmingTime": 10,
  "MaxTradeHoldDuration": 15,
  "MinFarmingDelayAfterBlock": 60,
  "OptimizationMode": 0,
  "SteamMessagePrefix": "/me [Bot] ",
  "SteamProtocols": 7,
  "UpdateChannel": 2,
  "UpdatePeriod": 24,
  "WebLimiterDelay": 300,
  "WebProxyUsername": null,
  "SteamOwnerID":REDACTED,
  "SteamTokenDumperPluginEnabled": true
}

BotName.json config of all affected bot instances

No response

Additional info

No response

JustArchi commented 7 months ago

You didn't include full log.txt as asked during issue creation - please provide that.

JakeyPrime commented 7 months ago

Yeah, it was a long one, and didn't really want to redact that much information, but here it is: https://paste.hep.gg/ifaxy.apache

JustArchi commented 7 months ago

2024-02-23 17:53:03|ArchiSteamFarm-1261774|INFO|ASF|InitCore() ArchiSteamFarm V6.0.0.2 (linux-x64/12398377fa0b4effa5aa6cb3e3025a92 | .NET 8.0.2; linux-x64; Ubuntu 22.04.4 LTS) in [/root/steam]

Okay, so this is latest prerelease and not stable release as you pointed out in your issue. That changes a lot, thanks, I'll need to verify if that part wasn't hit by some kind of regression due to V6 changes.

JakeyPrime commented 7 months ago

Ah, my fault, I don't recall ever clicking to run pre-release. I appreciate you looking into it.

JustArchi commented 7 months ago

Ah, my fault, I don't recall ever clicking to run pre-release. I appreciate you looking into it.

"UpdateChannel": 2, :wink:

JustArchi commented 7 months ago

Thanks for report, this issue should be fixed as of V6.0.0.3.

JustArchiNET / ArchiSteamFarm