JustArchi
commented
3 months ago You have 6 exceptions, but only 4 bots. Didn't you send unpack ASF two times at once?
Closed Citrinate closed 3 months ago
JustArchi
commented
3 months ago You have 6 exceptions, but only 4 bots. Didn't you send unpack ASF two times at once?
JustArchi
commented
3 months ago Ah okay, now I see, there are 6, so each bot threw that exception.
The question stands however, are you sure there weren't two consecutive fetch requests? If not, how many items in inventory those accounts have, more than 5k?
Citrinate
commented
3 months ago I've only been able to reproduce this error when I make 2 or more fetches in quick succession. The less time between fetches, the more likely there will be an error. The number of items in each of these inventories is: 448, 79, 34, 34, 35, and 663.
The chat that produced the log above is:
[11:09 AM] Citrinate: !status asf
[11:09 AM] BotA:
<citrinate> Bot is not farming anything.
<BotA> Bot is not farming anything.
<BotB> Bot is not farming anything.
<BotC> Bot is not farming anything.
<BotD> Bot is not farming anything.
<BotE> Bot is paused or running in manual mode.There are 6/6 bots running, with total of 0 games (0 cards) left to farm.
[11:09 AM] Citrinate: !unpack asf
[11:09 AM] BotA: <citrinate> Success!
<BotA> Success!
<BotB> Success!
<BotC> Success!
<BotD> Success!
<BotE> Success!
[11:09 AM] Citrinate: !unpack asf
[11:09 AM] BotA: <citrinate> Done!
<BotA> Done!
<BotB> Done!
<BotC> Done!
<BotD> Done!
<BotE> Done!Okay, that explains everything, could you check how much time you need before it starts working again? Roughly, in seconds, before you get at least one success, since the moment it stops working.
Citrinate
commented
3 months ago It never stops working completely, it's just that individual fetches may fail. If one fails, the next one usually succeeds.
For example, if I make one request every second I might see a string of: Success, Success, Fail, Success, Fail, Success, Success.
I haven't seen any fails when I test 1 fetch every 5 seconds either from my 79 item bot or my 663 item bot.
JustArchi
commented
3 months ago Great, that's very valuable info, thanks a lot, I should be able to make the method more robust now. Will do that and then release new version for you to test :+1:
JustArchi
commented
3 months ago I've marked V6.0.1.18 for release with this fix. If you'll get any further issues with the new method let me know. It seems we need similar level of bulletproofing as old AWH method, that simply already has it implemented by me before (sigh).
Checklist
ASF version
Latest pre-release
ASF variant
generic (with latest .NET runtime)
Bug description
ArchiHandler.GetMyInventoryAsyncsometimes throws an exceptionExpected behavior
No errors or error handling
Actual behavior
System.Net.Http.HttpRequestException: Failed due to error: DuplicateRequestSteps to reproduce
unpack asfunpack asfagainJust using
unpack asfas an easy way to callArchiHandler.GetMyInventoryAsynchere. My inventories have no booster packs in them. This can also be reproduced by sending the command to a single bot instead of all bots, ex:unpack BotAPossible reason/solution
No response
Can you help us with this bug report?
No, I don't have time, skills or willings for any of that
Full log.txt recorded during reproducing the problem
Global ASF.json config file
No response
BotName.json config of all affected bot instances
No response
Additional info
In regards to what I described here: https://github.com/Citrinate/BoosterManager/commit/d68141d1ae0cb6294de21706fd0efa1dd8522ceb#commitcomment-140273865
I wasn't running commands then as quickly as I'm doing here to get this error. Though in my testing here, I was able to get an error on one occasion after sending only 2
unpack asfcommands since logging on; so it's possible that maybe I was for a brief period.I'll continue testing to see if I get any more errors.