search

JustArchiNET / ArchiSteamFarm

C# application with primary purpose of farming Steam cards from multiple accounts simultaneously.
Apache License 2.0
11.3k stars 1.05k forks source link

[Suggestion] Ability to loot coupons #461

Closed r6d2 closed 7 years ago

r6d2 commented 7 years ago

Hi, Archi!

Would you consider to add the capability to loot coupons as well? I understand they are not on category 6, but it might become a handy feature, IMHO.

What do you think?

Best regards, --r6d2

JustArchi commented 7 years ago

What next? Steam gifts? CS:GO items?

I really don't think this is on ASF scope. Soon people would ask for looting all games and types ever created. Current LootableTypes are justified only because it's part of the same request that ASF has to do - if that wasn't the case, ASF would not have them either. Even if what you ask can be considered practical and useful, I don't really believe that it justifies another inventory request, not to mention that it's not on ASF scope at all. LootableTypes already went over the scope by introducing everything apart from trading cards and booster packs, I do not want to go above it, sorry. ASF is not inventory management tool.

Rudokhvist commented 7 years ago

Actuallly, sometimes it could be useful, because some coupons drop without badge crafting, just because you have some game, etc. But, it is really a different type, so implementing it will clutter the ASF code, and that's not desired (and we already have translations for that). And, the actual use cases are rare, and can be actually handled manually - bot's will accept your trade request, so this is not a lot of hassle, and I doubt you'll need same coupons from 100+ bots. TL;DR: I'm agree that this feature should not be implemented.

Pandiora commented 7 years ago

Uh, this needs a separate API-Call? (https://steamcommunity.com/id/[bot]/inventory/json/753/3/?trading=1)

JustArchi commented 7 years ago

Uh, this needs a separate API-Call? (https://steamcommunity.com/id/[bot]/inventory/json/753/3/?trading=1)

No, this needs a separate request, and ASF is not an inventory management tool to execute it in the first place.

Pandiora commented 7 years ago

Alright. At least I never needed this feature and never got any coupons for my bots. BTW: Lately you fixed some network-issue which solved SSL-Errors (Mono) for me, just in case this wasn't intended. Thanks anyway :+1:

JustArchi commented 7 years ago

I do not document many things in the changelog, because otherwise my changelog would need to have 200 lines that not only nobody would read, but also nobody would write - there are commits for exact history.

Major code improvements, optimizations and bugfixes.

This usually indicates stuff being fixed, but without specifying what exactly. It's enough to say that every new ASF version fixes something, even if it's not visible right away because you specifically didn't run into that fatal condition (yet). It's a good idea to always run latest stable, even if you believe that you do not need changes explained in the changelog - there is always lots of stuff "under the hood" that is being improved/fixed/worked on.

Pandiora commented 7 years ago

Okay, just wanted to let you know in case someone else reports the same problem with the latest or previous stable versions and a lot of bots (~100).