JustArchi
commented
7 years ago I think that someone would have a little bit of relief when he would know that there is only 49 out of 50 active bots, just before going to buy 50 games.
This is what !status ASF is for. Nothing guarantees you that other 49 accounts will log in successfully, regardless of their account flags.
I don't understand this suggestion at all - basically you want to stop bots in case of being limited, lockdown and disabled. For what reason? I can probably understand being disabled and in lockdown, as that could be permanent, but without data that backs up my theory I won't touch those flags as I don't know what they're responsible for. You shouldn't assume anything based on names alone - what matters for ASF is when and why those bits are being set, not the fact that they can be set. The fact is that being limited does not affect ability to log in, and it's absolutely inappropriate for ASF to force logoff in case of being limited, as there is crapload of people using limited accounts for executing commands to ASF, not to mention that being limited does not make it impossible for ASF to operate.
So the main question lies in - do you have any account that triggers lockdown/disabled bit and you can explain to me how that flag relates to account, and if it's permanent? Only then I can add support for it and decide how I want ASF to react to it - I don't agree at all with stopping bot in case of limitation, as it does not prevent ASF from working (such as receiving and answering to commands). If you for some reason don't want to use limited account in ASF, then simply don't enable given bot instance until you lift the restriction.
The entire logic in case of being limited was implemented only to solve questions like "why ASF doesn't idle my new account" and "why ASF idles my main account and doesn't drop cards anyway?". Since it's impossible to idle those accounts anymore, and we can check if account is limited in a nice way, I can also skip idling as it doesn't have a point, and people not aware of that can read the reason from the log. Even without that logic, ASF would work properly, with some features not working (like idling, hence I prefer to give a warning and stop trying instead of giving user false hope).
TheSergiooo
Rudokhvist
il-marc
Well, at first. Hello Github! I am registered an account here just to give you a little feedback. :D
So, im often mess up with ASF code, wielding its together with some other c# and c++ projects, turning it into an unstable abomination.
What comes like surprise to me, is that ASF successfully logins into lockdowned accounts without mentioning it. I have got less than 1% of this issues, but they were unpleasant. And i think that this one improvement will be useful for community. So, what i did is i opened
Bot.cs, and starting in line 1383 i found thisThen i took a look into SteamKit2 source code and found definition of EAccountFlags. And there were such flags as
EAccountFlags.LockdownandEAccountFlags.Disabled.Well, i dont know what Disabled mean, but looks like not something i want in my project, so i changed previous piece of code in bot.cs into
Personally for me its vital to stop exactly on this point and dont let to
OnLoggedOncontinue.Idea is simple, but for my purposes i need only two things: prevent account from being active and log that this account is locked, no more.
I think this would be nice if ASF would get more data from
EAccountFlagsand mentioning if is there something special about an account and doing some actions - likeStop();in case of Lockdown.Looks like some simple stuff, like
could be added already. I think that someone would have a little bit of relief when he would know that there is only 49 out of 50 active bots, just before going to buy 50 games.