JustArchiNET / ArchiSteamFarm

C# application with primary purpose of farming Steam cards from multiple accounts simultaneously.
Apache License 2.0
11.28k stars 1.05k forks source link

Idling stuck in a game until key pressed #489

Closed blue-lightning closed 7 years ago

blue-lightning commented 7 years ago

First, here's an image. Notice the jump from 19:02 to 22:38. So I set ASF up and let it run before leaving home at about 18:55. When I got back, ASF was stuck idling a game even after all the cards have been exhausted. Only when I pressed a key, in this case right-arrow, did ASF started checking card status again and switched to a new game.

JustArchi commented 7 years ago

Please review the guidelines for contributing to this repository.

https://github.com/JustArchi/ArchiSteamFarm/blob/master/CONTRIBUTING.md

If my issue is not meeting contributing guidelines specified above, especially if it's a question or technical issue, please close my issue immediately - I won't complain.

blue-lightning commented 7 years ago

The relevant log section is in the image link. I just encounter the bug today while I have been using ASF for a long time, so I guess it's unreproducable. No command was given because I only open ASF up and let it do it things. No account was given because I only have 1. So what additional information should I give for you to consider re-opening this issue, Archi?

JustArchi commented 7 years ago

Before reporting a bug you should carefully check if the "bug" you're encountering is in fact ASF bug and not technical issue that is answered in the FAQ or in other place on the wiki. Typically technical issue is intentional ASF behaviour which might not match your expectations, e.g. failing to send or accept steam trades - logic for accepting and sending steam trades is outside of the ASF, as stated in the FAQ, and there is no bug related to that because it's up to Steam to accept such request, or not.

https://github.com/JustArchi/ArchiSteamFarm/blob/master/CONTRIBUTING.md

blue-lightning commented 7 years ago

I'm not sure if I read the FAQ correctly, but shouldn't ASF check for card status every FarmingDelay, in default case 15 minutes, regardless of human interaction? This time it lasted for 3 hours.

JustArchi commented 7 years ago

Q: ASF seems to freeze and doesn't print anything on the console until I press a key!

I should probably add mandatory questions such as "Write 4th word in 139 line from FAQ" as pre-captcha before allowing anybody to post an issue 😕 .

blue-lightning commented 7 years ago

I thought so, but I did check my in-game status on Steam. The same game as displayed in the console log.

blue-lightning commented 7 years ago

Also I just check: in the log image I put up on the first post, you can see ASF reported that the game finished idling after 2 hours, 42 minutes. That's impossible as it must passed the 2 hours limit before cards start being given, and the game has 3 cards by default. Also, Steam reports my playtime not as 3 hours, but 6.

JustArchi commented 7 years ago

It doesn't matter at all to me what is the side-effect if you have quick edit mode enabled.

blue-lightning commented 7 years ago

So if I have quick edit enabled in ASF, I could by a small chance have ASF stuck idling indefinitely in a game until a key press was given. As this behaviour not only affect the display, but the function of ASF itself, I think maybe a reminder regarding this should be put in the FAQ, what do you think?

JustArchi commented 7 years ago

A reminder that you were supposed to read before creating this issue exists in a FAQ at least since a year.

blue-lightning commented 7 years ago

The FAQ said "seems to", not actually freeze the whole program. But I understand your decision. Sorry for having you put up with me.

JustArchi commented 7 years ago

I'll just disable quick mode permanently for ASF process, so people will stop asking about this once for good.

blue-lightning commented 7 years ago

That would do wonders for me. Thank you Archi, and again sorry for wasting your time on such trivia matters.