JustArchiNET / ArchiSteamFarm

C# application with primary purpose of farming Steam cards from multiple accounts simultaneously.
Apache License 2.0
11.29k stars 1.05k forks source link

ASF.xml #79

Closed JustArchi closed 8 years ago

JustArchi commented 8 years ago

Which will be used for:

lookerinside commented 8 years ago

I suggest global option for settings: SteamMasterID SteamMasterClanID Blacklist and may be most of others. I think at most of people most settings are similar except strong unicque such as username, password, apikey

JustArchi commented 8 years ago

SteamMasterID + ClanID must be bot-based, because one could want to run also bots for other people. Same with blacklist.

lookerinside commented 8 years ago

Let it be if in bot settings used some setting it will have much more priority than global and overwrite it for this bot

judgegr commented 8 years ago

Blacklist could be both global and bot-based, and may be merged when each bot starts. For example, a global blacklist might contain Summer/Winter sales IDs & known appIDs which would crash or make ASF act weirdly, whereas the bot-based blacklist might contain all other user-defined appIDs.

It's just a bit boring for Archi to code the merging of two blacklists, isn't it? :worried:

Rudokhvist commented 8 years ago

@judgegr Summer/Winter sales IDs and similar is already in the program code, and actually can be removed from configs. There is no much sense in putting it to a global config neither, because if autoupdate would be implementet thats the program what gets updated, not global config file. I thought about global blacklist too, but can't imagine any use case in which global blacklist would have advantages over local.

judgegr commented 8 years ago

Ah sorry didn't notice a hardcoded blacklist exists. Well in that case, i can't think how a global blacklist would help :+1:

JustArchi commented 8 years ago

Hardcoded blacklist is mandatory because otherwise even up-to-date ASF would be stuck if user defined his own blacklist.

So in ASF there are actually two blacklists - one, hardcoded global one, and second one - local, defined on per-bot basis by user in config. Hardcoded blacklist can't be changed, and I don't want to do that, because it should contain always up-to-date list of known "bad" apps, so user doesn't have to update all of his configs when some new app gets added to that list.

Hardcoded blacklist has exactly the same appIDs as default value for local one. And it should always be hardcoded. There's absolutely no possible case when you'd want to include globally blacklisted appIDs for farming.

Rudokhvist commented 8 years ago

While testing inventory I thought about one suggestion. Remember when I asked you to increase the timeout of web operations? I mean this one https://github.com/JustArchi/ArchiSteamFarm/blob/master/ArchiSteamFarm/WebBrowser.cs#L46 Maybe make it configurable now, if we would have global config file? By default it can be lower than now(to make errors messages appear a little bit faster), but it would be useful for people who want to start ASF on old PC (like my old crappy home server, sigh) or with a slow internet - they could increase it to make things work.

JustArchi commented 8 years ago

Definitely. Good idea.

Pandiora commented 8 years ago

Also add an option to define the delay between logins of multiple accounts when ASF starts.

JustArchi commented 8 years ago

Can be done.

JustArchi commented 8 years ago

Deprecated by #131