search

JustBlackBird / gulp-phpcs

Gulp plugin for running PHP Code Sniffer
MIT License
47 stars 12 forks source link

Log errors instead of emitting as an error #1

Closed robballou closed 10 years ago

robballou commented 10 years ago

Firstly, thank you for making this plugin, it's great that someone else is also trying to do this.

If the plugin emits the file as an error, then gulp-phpcs will stop at the first error. Currently this is just logging it with gutil.log which could be replaced with other reporting tools.

JustBlackBird commented 10 years ago

Hi!

Thanks for the PR but I cannot accept it. Here are the reasons:

  1. The way the plugin should deal with invalid files should be determined by reporters and not by validator. I've opened #2 for that and will implement it soon.
  2. You mixed several different changes in one PR.
  3. You left commented code and unused variables (it is not so important as previous two).
robballou commented 10 years ago

@JustBlackBird Reporters are the way to go. :+1:

(Sorry about the messy PR, I forgot it picks up subsequent commits)

JustBlackBird commented 10 years ago

@robballou, the reporters were added in v0.2.0