search

JustBlackBird / gulp-phpcs

Gulp plugin for running PHP Code Sniffer
MIT License
47 stars 12 forks source link

Normalize BIN path #13

Closed tyler36 closed 9 years ago

tyler36 commented 9 years ago

Assuming a UNIX style directory is listed, this will convert to Windows style if nessasary

JustBlackBird commented 9 years ago

I've learned more about Node.js path.normalize and there is a problem.

This function resolves both phpcs and ./phpcs to just phpcs. The problem is phpcs and ./phpcs are different things: the first one is a globally defined command and the second one is an executable file in the current directory. So we cannot use only path.normalize to solve the issue.

JustBlackBird commented 9 years ago

The best option is to use path.normalize in gulpfile.js (and only if it's really needed).