JustBlackBird / gulp-phpcs

Gulp plugin for running PHP Code Sniffer

MIT License

47 stars 12 forks source link

added phpcs report options #17

Closed di5abled closed 8 years ago

di5abled commented 8 years ago

and changed reporters to failOnError reporters to prevent conflicts in understanding

11

JustBlackBird commented 8 years ago

So why don't you just create a reporter that saves reports to file?

JustBlackBird commented 8 years ago

Also PHPCS running logic was intentionally decoupled from reporting stuff some time ago (see https://github.com/JustBlackBird/gulp-phpcs/commit/b60632d33484bb9478ac6c6788e546680a917c1b). And I've already describe my position about --reportFile option here.

di5abled commented 8 years ago

Why should I mimic the functionality someone already die in phpcs and rewrite them as an reporter if I could just use the build in phpcs ones. This makes no sense for me!?

I saw you comments on that and thouht this would be a solution to combine this two solutions.

So you see no way using also the native phpcs reporting options?

di5abled commented 8 years ago

I had another closer look at how everything is put together, I get the problem now, I'll have a look at a custom reporter :)

JustBlackBird commented 8 years ago

So you see no way using also the native phpcs reporting options?

I don't have anything against --report option, but I don't want to mix native PHPCS reporting to file with reporters already implemented in gulp-phpcs. It will end up with a mess. Also it makes plugin's usage harder.

Plugin's reporters have some benefits:

Reporters could implement any logic you want to (you can implement a reporter that sends problems to email or jabber).
Reporters could be used separately without reconfiguring the plugin itself.
Reporters can be chained in any order you want.
Each reporter encapsulates a single task which decrease total complexity of the code