search

JustBlackBird / gulp-phpcs

Gulp plugin for running PHP Code Sniffer
MIT License
47 stars 12 forks source link

feat: added file reporter #18

Closed di5abled closed 8 years ago

di5abled commented 8 years ago

another try :)

hope you like this more, really basic for the first version

JustBlackBird commented 8 years ago

Yes, you're right I like it :+1: Great job!

The only thing I cannot understand is why don't you use a callback function in fs.writeFile (here).

Also there are several minor problems (mostly with codding style and output consistency) but I can fix them by myself after merge.

di5abled commented 8 years ago

Hy,

true story, I fixed this.

JustBlackBird commented 8 years ago

Thank you. I've fix some problems, and release a new version after a while

di5abled commented 8 years ago

nice, hope you can release a new version soon ;)

di5abled commented 8 years ago

when will you bump the version? want to use this feature on my current project :)

JustBlackBird commented 8 years ago

The next version will be release right after I'll fix #19 (there were some changes in plugin's logic so I want to make sure everything is fine). If nothing will brake my plans I could finish today or tomorrow.

JustBlackBird commented 8 years ago

Done!