JustBlackBird / gulp-phpcs

Gulp plugin for running PHP Code Sniffer
MIT License
47 stars 12 forks source link

Bind to phpcs close instead of exit #30

Closed rbayliss closed 7 years ago

rbayliss commented 7 years ago

It is possible that I/O isn't finished before exit is called. See https://nodejs.org/api/child_process.html#child_process_event_close

This fixes a race condition where the error output is occasionally not reported, even though the exit code is.

JustBlackBird commented 7 years ago

Thank you!