search

JustCarmen / webtrees-fancy-imagebar

Fancy Imagebar module for webtrees
http://justcarmen.nl
GNU General Public License v3.0
12 stars 6 forks source link

Saving settings creates Internal Server Error #107

Closed AndreasRauhut closed 1 year ago

AndreasRauhut commented 2 years ago

With this version of TreeService.php, jc-fancy-imagebar works perfectly! Thanks to you!

Originally posted by @patrickfaivre in https://github.com/JustCarmen/webtrees-fancy-imagebar/issues/106#issuecomment-1125809009

Me too, but I can access the settings, but when I try to save changes I get an error screen. "Internal Server Error"

I tried to replace the original TreeService.php of the freshly installed jc-fancy-imagebar-2.2.0 by the above proposed version, but that didn't change anything visible to me.

Probably another problem ?

JustCarmen commented 2 years ago

I think this is the same problem as discussed here:

https://www.webtrees.net/index.php/en/forum/4-customising/36906-problem-with-fancy-imagebar-after-update-from-webtrees-2-11-to-2-12#92021

Fancy Imagebar is not tested against so many images and might not work as expected.

The image table on the settings page uses a native webtrees function to display the images. With so many images to display this takes a lot of resources. Perhaps I could make displaying the image table optional and/or make an option to turn it into a list without thumbnails to be able to (de)select certain images. This should reduce the amount of memory considerably.

There may be other options, but this is what I'm thinking of right now. But it takes time to make such adjustments so don't expect it anytime soon.

arbor95 commented 1 year ago

+1 would like that change (I always check all images until now)