search

JustCarmen / webtrees-fancy-imagebar

Fancy Imagebar module for webtrees
http://justcarmen.nl
GNU General Public License v3.0
12 stars 6 forks source link

.jc-fancy-imagebar-map: Firefox inspector shows "overflow" #84

Closed ungeahnt closed 3 years ago

ungeahnt commented 3 years ago

fc-imagebar creates more than 700 'area shape' entries. Up to:

<area shape="rect" coords="100887, 0, 100947, 80" alt="Elisabeth Beppie Honig (1897–1984)" title="Elisabeth Beppie Honig (1897–1984)" href="https://wijzijnfamilie.nl/tree/wijzijnfamilie/individual/I3287/Elisabeth-Beppie-Honig" data-coords="100887, 0, 100947, 80">

Is this a problem? I guess even a 4k monitor doesn't need that many images?!

grafik

JustCarmen commented 3 years ago

700 images is way to much. I wasn't able to reproduce this.

But I think I have improved the performance by using another calculation method to determine the amount of images needed to fill up the entire imagebar.

The width of each thumbnail is calculated and processing stops as soon as the total width reaches the width of the imagebar. If there are less images to fill up the entire imagebar the average width of the processed images is used to determine the number of extra images. This gives a more accurate result without wasting resources.

Hope this helps.

JustCarmen commented 3 years ago

See my last comment at #69. Since this issue is related I think this issue is also solved with the latest commits.

I will close this issue now. If you still have troubles please open a new issue.

ungeahnt commented 3 years ago

First: Thanks a lot for V2.1.2. It brings a real performance boost!

But I see this "overflow" also with V2.1.2 (Firefox web-dev-tools) but it's not a problem for me (I hope so ;) ). So I won't open a new issue.

Only for completness:

700 images is way to much. I wasn't able to reproduce this.

I must have misinterpreted the Firefox information. Probably no 700 thumbs are generated, but it is about the links (maps/coords?) between INDI and thumbs?

With the update to V2.1.2 fc-imagebar creates on my website (proavitus.de) 331 items of "area shape" with coords from area shape="rect" coords="158, 0, 217, 80 to area shape="rect" coords="59195, 0, 59256, 80 and Firefox shows an "overflow" (equal to the image above).

Maybe this is intentional, that the coords go to 59256, but I'm just wondering, since the jpeg-file that is created on my site is only of the size of 3840x80 pixels (dual-monitor) and includes only 61 (and a half) thumbs.

As mentioned above, I have no problem with that. I just noticed it and thought it might be a performance problem.