search

JustCarmen / webtrees-theme-justlight

JustLight theme for webtrees
http://justcarmen.nl
GNU General Public License v3.0
31 stars 7 forks source link

Formatting of notes not correct #111

Closed mpwt closed 2 years ago

mpwt commented 2 years ago

In webtrees v2.1.2 and webtrees-theme-justlight v2.2.0 notes are displayed differently. For multi-line notes there is only a line break after "Note:", for single-line notes there is a line break after "Note" and ":".

display_of_notes

With justlight 2.1.2.3 this was solved better, the note was displayed directly after "Note:".

display_of_notes_V2 1

Thank you for your work and the great theme.

JustCarmen commented 2 years ago

This should already be solved with this commit: https://github.com/JustCarmen/webtrees-theme-justlight/commit/c758c5983cd459c88778c2584be8da7273b03678

The notes are very difficult to style. Perhaps you can test whether this solves your problem sufficiently.

mpwt commented 2 years ago

Thank you for the quick feedback and the code change that has already been made. After copying the changed file resources/views/theme/script.js.phtml it looks better, but there is still a line break after "Note:" or the note itself always starts on a new line.

notes_new
mpwt commented 2 years ago

The remaining line break seems to be a bug in webtrees. See https://github.com/fisharebest/webtrees/issues/4400.