search

JustCarmen / webtrees-theme-justlight

JustLight theme for webtrees
http://justcarmen.nl
GNU General Public License v3.0
31 stars 7 forks source link

Places in wt 2.1.17 on small devices (or screen) #145

Closed arbor95 closed 1 year ago

arbor95 commented 1 year ago

see https://github.com/jon48/webtrees-theme-rural/issues/62 and https://github.com/fisharebest/webtrees/pull/4774

If you want, I can take screenshots with justlight theme.

arbor95 commented 1 year ago

It seems as if the changes from https://github.com/fisharebest/webtrees/pull/4798 have to be implemented in your theme.

arbor95 commented 1 year ago

Could you please fix this error please. I use the Places tab as the first tab and if there is no map it is really not nice. The error only shows up on mobile phones or on a correspondingly reduced window.

arbor95 commented 1 year ago

you can see a working solution (fix) at another theme: https://github.com/06Games/Webtrees-ArgonLight/commit/2ada337b201b3987ca024d1e3637bc269f2155ab

JustCarmen commented 1 year ago

Did you test it against the latest dev version or the stable release? Cause I think this is already implemented in the lates dev version. The dev code contains webtrees 2.1.17 css with a fixed height on the places map.

arbor95 commented 1 year ago

I used 2.1.17 . How should I create a dev - version as "normal" windows user. But we can ask the creator of the argon-light theme. His response time is one of the best.

arbor95 commented 1 year ago

With 2.2.6 the map is visible again in all cases. Moving complete screen may be a bit tricky in some cases. I still like best the solution of the Argon Light theme, where the legend scrolls independant from the map. It is more intuitive for the user, if you want to scroll/move the complete screen.