search

JustDerb / yed-aws-palettes

yED palettes imported from https://aws.amazon.com/architecture/icons/
MIT License
52 stars 3 forks source link

add resource icons #6

Closed ChipNowacek closed 1 year ago

ChipNowacek commented 1 year ago

Thank you for doing all this. It's so helpful.

Any chance you could add the resource icons? I see them on screenshot but not in the palettes: image. If you tried and ran into trouble, could you tell me which commit you think came the closest and I'll try from there?

Thanks again.

ChipNowacek commented 1 year ago

Did the resources get lost because AWS reshuffled the packaging and split it out of architecture?

JustDerb commented 1 year ago

Hmm... it might have been. They love changing the packaging of their files for this, so it's alway chasing a moving target. If you find the root cause feel free to add it here. The https://github.com/JustDerb/yed-aws-palettes/blob/master/update.sh script will simply need to be updated to pull and place the files in the correct directories.

I won't have a ton of time in the coming weeks to root cause what's going on, so your alternative is to manually download the files and manually import them into the Palettes for now. Sizing might be different as an fyi.

ChipNowacek commented 1 year ago

The challenge is two-fold: size and folder structure.

Size

You are currently grabbing the "32-pixel" svg files. That happens on line 110. That is indeed the best "size" for yEd palettes. Unfortunately, as of today (2023-09-15), AWS is only shipping "48-pixel" svg icons for resources. We'd need to use ImageMagick or something similar to resize the resource icons.

Folder structure

Here's the current structure. image

The folder decision is made on line 39. We better put the resource icons in the architecture palettes. yEd doesn't handle lots of palettes very well. When there are too many, the scrolling on the palette window gets janky.

I will hack at it if I get a chance.

Again, thanks.

JustDerb commented 1 year ago

Hey, see if https://github.com/JustDerb/yed-aws-palettes/commit/5879378e667193b88ce6b869c3b9584853c41c9f solves the issue for you.

AWS is only shipping "48-pixel" svg icons for resources

The translator actually should resize the SVGs so they are all the same size. I confirmed in the latest yEd software that they all can be dragged into the editor and appear to be the same size.

ChipNowacek commented 1 year ago

Thanks so much. I'll try shortly.