Fix build:docs command - Githubissues

JustFly1984 / react-google-maps-api

React Google Maps API

MIT License

1.76k stars 426 forks source link

Fix build:docs command #3220

Closed crtl closed 1 year ago

crtl commented 1 year ago

Replaces awesome-typescript-loader with ts-loader
Excludes */.stories.tsx files from styleguidist build
Fix acorn parse error by adding missing semicolons and slash to self-closing-tag

JustFly1984 commented 1 year ago

@crtl are you continue to work on this, or should I merge it as is?

crtl commented 1 year ago

@JustFly1984 I thought you wanted to review it? You can merge it but I dont think the docs are really correct. Ive just fixed the build:docs command so it does not throw errors anymore because you said you are unable to run it. Problem is that it now only shows the [ComponentName]F components (ie functional implementation) in the docs and not the [ComponentName] anymore. For Example docs will have MarkerF component but no Marker component.

JustFly1984 commented 1 year ago

Well, if docs built with react@17+, it can't make sense to use old broken class components... The other way would be to fix old components to support react@17+... but I simply have no time. Your PR is very welcome.