search

JustFly1984 / react-google-maps-api

React Google Maps API
MIT License
1.75k stars 421 forks source link

add useEffects in MarkerF for clickable, cursor, icon, label, opacity, shape, title, zIndex #3332

Closed Fabioni closed 4 months ago

Fabioni commented 5 months ago

fixes:

In MarkerF in https://github.com/JustFly1984/react-google-maps-api/blob/fbf7b24d48ac0030efd9930abb6d56efa64bf4fa/packages/react-google-maps-api/src/components/drawing/Marker.tsx#L180-L283 , there was only useEffects for some properties but not for all, which had the problem, that some property changes did not trigger re-render. Most prominent one is icon.

Fabioni commented 4 months ago

Hey, thanks for merging. When do you release that to npm? @JustFly1984

JustFly1984 commented 4 months ago

@Fabioni released 2.19.3, please test

Fabioni commented 4 months ago

@JustFly1984 works for me 👍🏼

Fabioni commented 4 months ago

@JustFly1984 I think you could also close the related issued to notify them

JustFly1984 commented 4 months ago

@Fabioni can you please post links to issues to close?

Fabioni commented 4 months ago

The issues are referenced in the pull request