JustInvoke / Randomation-Vehicle-Physics

Vehicle physics system for the Unity engine.
https://justinvoke.com/game-assets/#randomation-vehicle-physics
865 stars 184 forks source link

Ai adds instanced physics materials to other objects #54

Open neshail opened 2 years ago

neshail commented 2 years ago

Ai changes the physics materials set in scene. Which fights with our objects setting specific physics materials in code in order to achieve different outcomes.As a result playmaker cannot get the new Instanced physics materials or set them to work with our custom physics.Which results in both physics fighting of setting different physics materials.So as the ai is driving on different objects in terrain and road we can no longer get these physics materials and set them.

JustInvoke commented 2 years ago

Unfortunately I don't intend to officially support PlayMaker at any point in the future.

neshail commented 2 years ago

Hi Its not about playmaker it is about setting its own instanced physics material that cannot be touched even in script which interferes with other objects physics materials which is anoying. Eg:when it is raining in the scene we change the physics materials in game however randomation sets it faster which is anoying.Do you have any ideas to fix it this is for a company which has an interest in randomation physics.THANK YOU

On Sat, Dec 18, 2021, 10:24 PM Justin Couch @.***> wrote:

Unfortunately I don't intend to officially support PlayMaker at any point in the future.

— Reply to this email directly, view it on GitHub https://github.com/JustInvoke/Randomation-Vehicle-Physics/issues/54#issuecomment-997280095, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASLNNCG47ERW3SZTPJT4XX3URTUY5ANCNFSM5KGQYDYQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

JustInvoke commented 2 years ago

Ok I think this is because there were places where physic materials were being referenced through collider.material which creates (and I believe assigns) a new instance of a material. I just committed a change where these are replaced with collider.sharedMaterial which should allow you to modify physic materials at runtime and not have them be overwritten.

neshail commented 2 years ago

Thank you tremendously for resolving the issue i could not be more gratefull.It would be extraordinarily helpful if you could advise on why the ai is so bumpy despite driving on a flat surface it appears as if the ai is driving over bumps continuously and wobbles.I used the same setup from the demo scene yet still gives the same issue.Also there is a suspension error that occurs from time to time on the ai at random.When our team can replicate the error we will get back to you it results in significant performance drops.I thank you so much for your speedy helping us resolve these tiny issues.

JustInvoke commented 2 years ago

I'm not sure what's causing the bumpiness other than possibly the use of wheels groups on VehicleParent. You can try setting the array size to 0 to disable them. Let me know if you catch the suspension error again.