search

JustJoostNL / F1MV-Lights-Integration

The best way to connect your smart home lights to MultiViewer.
https://f1mvli.jstt.me
GNU General Public License v3.0
24 stars 9 forks source link

added magic-home integration #31

Closed LordBrud closed 1 year ago

LordBrud commented 1 year ago

I added magic-home and tried to follow your structures. I must've missed something because the API check always shows red even though everything should be enabled and the connection works. Since you have infinitely more experience with adding new Integrations to your App than I have, I thought you might be able to figure it out quicker than me.

I was thinking about putting the code in a separate file and not to main.js but I didn't want to make too many changes to the rest. Maybe that's something for the future. As well as an easier process to add a new setting with more dynamic stuff so you don't have to duplicate so many lines.

Feel free to comment, request changes, or change something directly.

JustJoostNL commented 1 year ago

@LordBrud Hey! Thanks for your contribution, I appreciate it! I already took a quick look, and it looks great! I will do some further reviewing tomorrow!

JustJoostNL commented 1 year ago

Won't be added since I am busy with a rewrite (should be done soon). And this is already covered by Home Assistant.