search

JustMaier / angular-signalr-hub

Handy AngularJS factory for SignalR Hubs
MIT License
291 stars 78 forks source link

Simple Chat Demo link broken. Also, documentation unclear generally #73

Open BenMcLeanHRBlock opened 8 years ago

BenMcLeanHRBlock commented 8 years ago

The link to the Simple Chat Demo in the readme is broken.

I haven't managed to get the signalrgrid demo working either. Some of the dependencies won't resolve even though I've tried downloading and installing them with NuGet. Does it perhaps need to be updated?

Also, the documentation for this is pretty unclear. Ideally we'd want to see a clear absolute minimum example which only displays the simplest possible data (first example shouldn't even modify the data: do that in a more advanced example) and compare what the code would look like with angular-signalr-hub versus doing it with just angular and signalr.

On second thought, it might be even better to have the absolute minimum example not even do anything except display "Hello world!" from the server calling a client method. Most SignalR tutorials and documentation I find online seem to be piling too many things on at once.

The example with "Employees" seems to be using the same word "Employees" to describe clients on the web site AND the data being displayed, and that is very confusing. An example that sharply distinguishes between these things in it's choice of identifier names would help in understanding how to use this. Also, I'm not clear on why it depends on OData instead of just the Web API: that makes it difficult to untangle the OData dependent parts from the pure angular-signalr-hub parts,

DeBiese commented 8 years ago

I just checked the link to the simple chat demo. Something went wrong with the settings in onedrive. Try this url for the demo: https://onedrive.live.com/redir?resid=A384F349DF30AC50!34027&authkey=!ABcHiikiie50aCM&ithint=file%2czip

BenMcLeanHRBlock commented 8 years ago

That new link doesn't work either, sorry. I get, "This site can’t be reached

The webpage at https://onedrive.live.com/redir?resid=A384F349DF30AC50!34027&authkey=!ABcHiikiie50aCM&ithint=file%2czip might be temporarily down or it may have moved permanently to a new web address." in Google Chrome.

However, it's entirely possible that this may be a firewall issue on my end. Could you try uploading it to Github?

JustMaier commented 8 years ago

Hey @BenMcLeanHRBlock, does this one seem to be working for you?

https://dl.dropboxusercontent.com/u/8501621/Spikes.RubenB.SignalR.zip

BenMcLean commented 8 years ago

I have discovered that the former link works from another location so it actually was a firewall issue.

BenMcLeanHRBlock commented 8 years ago

Still, corporate networks being what they are, it would be very helpful if this could be uploaded to Github, because apparently a service that shares files between peers like Github and a service that does peer-to-peer filesharing like DropBox and OneDrive are two different things in the corporate mind.

JustMaier commented 8 years ago

It would be more convenient if it was on GitHub as well. Is that something you can do @DeBiese, or should I take your code and create a repo for it myself?

DeBiese commented 8 years ago

It might be somewhat late, but the sample code is now available on github .

BenMcLean commented 8 years ago

Actually, that is very helpful. Thanks very much! I hope you get that blog post published soon. :)

DeBiese commented 8 years ago

No problem. I do need to stress that I did not get the sample up to date with the latest version. I haven't done anything with signal-r recently.

And that blogpost is online now. (Link updated on DeBiese-Code-Bucket)