search

JustOff / advanced-night-mode

Advanced Night Mode
https://justoff.github.io
20 stars 2 forks source link

Alters Palemoon Dialogs as well #2

Closed AnthoniG closed 6 years ago

AnthoniG commented 6 years ago

It's a great extension and very useful for my eyes. However I noticed that it alters all Palemoon Dialogs as well and it makes it impossible for me to see them.

If there was a way to have it so you can not activate on dialogs, then that would be perfect. Until then I have it disabled :disappointed:

JustOff commented 6 years ago

Could you please give me an example with a screenshot?

AnthoniG commented 6 years ago

https://imgur.com/a/r50fc --> Bookmark Edit https://imgur.com/a/b94C2 -> LastPass Edit

JustOff commented 6 years ago

Hm... I can't reproduce it in my Win7 box with classic theme.

2018-03-13_15-17-20

What OS and PM theme are you using?

AnthoniG commented 6 years ago

OS = Linux Mint 18 (Sylvia) Theme = Walnutty 1.1.0

AnthoniG commented 6 years ago

If I disable the Walnutty theme then it does not alter the dialogs. However it messes up All-In-One-Sidebar :cry:

JustOff commented 6 years ago

@Lootyhoof, could you please take a look why Walnutty can have such an impact on dialogues when interacting with ANM?

Lootyhoof commented 6 years ago

Walnutty (as well as several other themes) do not use native styling for these elements, hence they are also affected by your styling. If you only want your extension to affect page content and not UI, you should add the HTML namespace to your CSS.

JustOff commented 6 years ago

Thank you @Lootyhoof, now I see.

@AnthoniG, open chrome://browser/content/places/editBookmarkOverlay.xul in a new tab and use ANM button to disable color processing for chrome://browser (or more specific path). Repeat these steps for chrome://lastpass/content/lastpass.xul and any other dialogues you have problem with. You can also try so select Simple CSS processing mode instead of Disabled, looks like it also produces good result.

AnthoniG commented 6 years ago

@JustOff

Switching to SimpleCSS does the trick. Have not even had to add in the disable for any chrome:// paths. All I wanted to do was to be able to read the dialogs BUT still keep ANM active :grinning:

If I still get trouble however I now have a direct fallback (disable certain chrome:// paths), so that is definitely something to keep in mind.

Thank you very much for your help. Love your extension, saves me immense eye strain :smile:

If want this can be closed now ?

JustOff commented 6 years ago

You are welcome.

AnthoniG commented 6 years ago

@JustOff One other quick question How do I find the path for the extensions I want to 'disable / blacklist' ?

For example I need to do the chrome:// thing for Session Manager and I've tried

chrome://lastpass/content/session_manager.xul chrome://lastpass/content/session.xul

etc and none worked. Is there some place I can look this up please ?

JustOff commented 6 years ago

Look inside the extension package (I recommend Extension Source Explorer for this). Let's for example explore Session Manager: its chrome.manifest defines sessionmanager as the content prefix, so we can search by chrome://sessionmanager/content to find necessary xul overlays.

You can even manually edit extensions.AdvancedNightMode@Off.JustOff.configured_pages in about:config, but ANM need to be restarted (Disable/Enable) in order to apply changes. If you use chrome:// pattern there, you can even change the processing mode for all existing overlays of the browser and extensions.

AnthoniG commented 6 years ago

Thanks for that. Much appreciated.