JustOff / advanced-night-mode

Advanced Night Mode
https://justoff.github.io
20 stars 2 forks source link

Issues with transparent images that use black text color #9

Closed Rava77 closed 5 years ago

Rava77 commented 5 years ago

Hi, usually advanced-night-mode works fine, but not with svg graphics, like the ones wikipedia uses. System x86-64 Linux, Palemoon 28.4.0 When the graphics has black text or black lines or other stuff drawn with the colour black, advanced-night-mode sets the background colour to black (as it should) but the svg drawn text or image colour black is left as it is, so we have black on black. Only different colours are visible. Example: E.g. this svg https://de.wikipedia.org/wiki/Datei:Aliasing_mrtz.svg with advanced-night-mode only shows the large red sinus like graph, but the rest, like the smaller / narrower black sinus graphs and all the other details are unseen cause they are black on black. "Invert" also not works, only switching advanced-night-mode off for all de.wikipedia (or en.wikipedia…) pages works, but that also means bright white background that I try to avoid.

JustOff commented 5 years ago

Unfortunately, this problem is always observed with transparent images that use black text color and there is no general solution.

As a workaround, you can add the following rule to userContent.css:

@-moz-document domain("wikipedia.org") {
  .fullImageLink a img {
    background: lightskyblue !important;
  }
}
Rava77 commented 5 years ago

Thanks, your fix works like a charm, unfortunately, only for the svg file as linked above. On the article page - https://de.wikipedia.org/wiki/Alias-Effekt - the image is still shown as black on black. Sadly I am not that skilled with css that I could alter @-moz-document to what it needs to be to cover both svg links and wikipedia entry pages…

JustOff commented 5 years ago

You can try a less strict selector:

@-moz-document domain("wikipedia.org") {
  a img {
    background: lightskyblue !important;
  }
}