search

JustOff / dismiss-the-overlay

Dismiss The Overlay
https://justoff.github.io
12 stars 2 forks source link

Only shows on first window #7

Open petercooperjr opened 3 years ago

petercooperjr commented 3 years ago

This button appears only on the toolbar of the first window. That is, I added this add-on and the button for it appears at the end of my toolbar. But when I open a second window (Pale Moon button / New Window) the button isn't there on any additional windows. I would have expected it to be there on all of the windows.

JustOff commented 3 years ago

Please provide the steps to reproduce this issue using a new, unmodified browser profile where DTA is the only extension.

petercooperjr commented 3 years ago

I apologize for the terseness of my original report; hopefully here are better repro steps:

I'm using Pale Moon 29.1.1 64-bit on Windows 10 Home Version 20H2 Build 19042.928

  1. Run palemoon.exe -profilemanager
  2. Click Create Profile, Next, name it "DTO-test", Finish, Start Pale Moon (so I'm starting with a brand new profile with no other add-ons)
  3. Go to https://github.com/JustOff/dismiss-the-overlay/releases/tag/1.0.7 and click dismiss-the-overlay-1.0.7.xpi
  4. Choose "Install Now"
  5. The Dismiss-the-Overlay add-on is now installed and has a button on the right side of the toolbar.
  6. Click the Pale Moon button in the upper-left, and choose New Window
  7. In this second window, the Dismiss-the-Overlay add-on button does not appear on the right side like I expected.
  8. Close that second window, and then in the original window click the Pale Moon button in the upper-left, and choose New Private Window
  9. Similarly in private windows, the Dismiss-the-Overlay add-on button does not appear on the right side like I expect.
  10. Even after closing the browser, and opening it again with that "DTO-test" profile, the button appears on the originally opened window but not any additional New Windows.
JustOff commented 3 years ago

Unfortunately, I can not reproduce the issue according to your script, the button is shown in all new windows, including private. Do you use the official version of Pale Moon? Are there any error messages in the browser console (Ctrl+Shift+J) when you open a new window?

petercooperjr commented 3 years ago

Hmm… I don't think I'm using anything special; it's just the normal 64-bit Pale Moon. The button isn't there in new windows for me across three different computers. I don't see anything in the Browser Console that gets added when I try to open a new window. I'll keep digging and see what I might be doing differently; I hadn't actually tried it in a new profile until I put together those repro steps. But it seems the same to me whether it's in my main profile or in a new one. Maybe I can narrow down what's different between our systems.

petercooperjr commented 3 years ago

It looks like I can manually Customize the toolbar and add the button to it in a new window, and then it stays there when I open new windows. So it's like it's only on the first window by default, but if I add it to the toolbar separately via Customize then it stays there? Seems kind of confusing, and I'm not sure what I'm doing differently than you, but I guess that's a fine "workaround" for now that if it disappears I can add it and then it seems to stay. Still something weird going on, though, I think.

JustOff commented 3 years ago

I'm not sure that it will help to figure out what is happening, but could you try to reproduce the problem using a portable version?

JustOff commented 3 years ago

Well, I was finally able to reproduce this problem in a virtual box, however, the fix will require additional research.

petercooperjr commented 3 years ago

Thanks for digging into it more! I'm really quite curious what's the same about my computers and your virtual box that's different from your usual systems where it works for you.

I did just now try it in Pale Moon Portable (29.1.1, 64-bit), freshly extracted, and it works the same way as far as I can tell

  1. Go to https://github.com/JustOff/dismiss-the-overlay/releases/tag/1.0.7
  2. Click "dismiss-the-overlay-1.0.7.xpi" and then "Install Now"
  3. Button for Dismiss-the-Overlay is on right side of the window now
  4. Pale Moon button, New Window
  5. The button for dismiss-the-overlay isn't on the toolbar of the new window
  6. Same thing after closing and re-opening the palemoon-portable.exe; the original window has the button but any additional windows (New Window or New Private Window) don't, unless I specifically add it to the toolbar with Customize.