Argh.. GitHub is broken again

[jrfnl]

Yup... GH has done it again.... must be driving you bonkers..

I see this error in the console:

TypeError: (intermediate value).attachShadow is not a function[Learn More] chunk-index2-a8e52977.js:1:2276

As for symptoms:

• Drop down on a comment (to edit the comment, for instance) not working.
• No notification showing for a newly pushed branch on the "Pull" page.
• etc

[ghost]

Sorry, but this is unlikely to happen.

+1.

If Pale Moon even would fully stop work with GitHub, I'm able to launch Firefox to report issues here.

[Vangelis66]

so we can report issues at least

You can always use a different browser for this.

If Pale Moon even would fully stop work(ing) with GitHub, I'm able to launch Firefox to report issues here.

... "Always" is such a strong word in this context... 😉 ; "always" and "launch Firefox" isn't always (pun intended 😃 ) feasible for ALL users of this life-saving extension...

When M$/GitHub toyed with the idea of optional chaining operator ("?.") on Feb 8/9th, I was fortunate enough to have ONLY ONE browser available on my system that could render GitHub, a Chinese-made Chromium 86 fork (360EEv13); more so fortunate, because support for OCO ("?.") was only added in Chromium 80; and, though you can somehow polyfill "methods", you can't polyfill "operators" :disappointed: ; mind you, this GH experiment provoked #43 and the issue reporter there runs WinXP, where "launch (latest) Firefox" isn't possible, either...

The Chinese have stopped producing Chromium forks >=87.0 that the retrocomputing communities (Windows < 7) can make use of; so, when M$ start implementing ECMAScript2021+ "goodies" not supported in Chromium 86, and depending on the scale of GH breakage on UXP itself, I foresee it might be quite difficult for "me" to report issues "here" 😜 ; "always" would then mean switching to a laptop in my household that can run the latest "mainstream" browsers endorsed by GH 😠 ...

If I'm allowed to voice my opinion here 😉 , mirroring this repo in a more browser-agnostic platform isn't a bad idea at all, if not by the extension maintainer himself (after all, it's his own prerogative 😄 ), then by some other member of this community; I'd do it myself, had I been more versed in coding... 😭 Anyhow, just my 2c...

[SeaHOH]

A better fix #48

[buc-me]

SeaMonkey

FTR, SeaMonkey 2.53.9.1 has no problems with the user menu with both 1.2.12 and 1.2.13b2, while 2.53.10 has.

The reason is a fix for Mozilla's bug https://bugzilla.mozilla.org/show_bug.cgi?id=1391154, which has been backported to SeaMonkey since the version of 2.53.10 . Reverting this backport fixes the issue.

Probably will be fixed in the next release of SeaMonkey.

[dirkf]

This? https://gitlab.com/seamonkey-project/seamonkey-2.53-mozilla/-/commit/1a9bb8dcae068ea13ddbabcb5620f4e5ab0ea1f8

Why isn't FF affected? Or do you just have to use a version old enough to have the fix?

[buc-me]

dirkf wrote:

This? https://gitlab.com/seamonkey-project/seamonkey-2.53-mozilla/-/commit/1a9bb8dcae068ea13ddbabcb5620f4e5ab0ea1f8

Yep.

Why isn't FF affected?

Because FF do not need this addon... :)

[dirkf]

So the bug is really in the way some (include-fragment?) polyfill is being applied in the various affected versions of the extension? I don't think SM should be re-broken for that.

Maybe better just to add a SM.2.53.10+ tweak to the extension to replace the ridiculous <include-fragment> menu with a link to https://github.com/settings/profile?

Anyway as you say, on 23/02/2022 21:57, Frank-Rainer Grahl (@ frg) https://gitlab.com/frg commented:

Has already been worked around in current 2.53.12b1 pre. Was too late for 2.53.11 final:

https://ircbot.comm-central.org:8080/seamonkey/20220221#c191872

[roytam1]

got these today in network graph:

07:32:40.160 TypeError: (intermediate value).attachShadow is not a function 1 vendors-node_modules_github_clipboard-copy-element_dist_index_esm_js-node_modules_github_filt-19a0ad-b0aa79d964b0f0b0715d.js:1:21178
    a https://github.githubassets.com/assets/vendors-node_modules_github_clipboard-copy-element_dist_index_esm_js-node_modules_github_filt-19a0ad-b0aa79d964b0f0b0715d.js:1:21178
    d https://github.githubassets.com/assets/compat-838cedbb.js:1:2412
    y.prototype.l/</< https://github.githubassets.com/assets/compat-838cedbb.js:1:5435
    y.prototype.l/< https://github.githubassets.com/assets/compat-838cedbb.js:1:5074
    y/this.f https://github.githubassets.com/assets/compat-838cedbb.js:1:3304
    y.prototype.l https://github.githubassets.com/assets/compat-838cedbb.js:1:5048
    [61075] https://github.githubassets.com/assets/vendors-node_modules_github_clipboard-copy-element_dist_index_esm_js-node_modules_github_filt-19a0ad-b0aa79d964b0f0b0715d.js:7:450
    _ https://github.githubassets.com/assets/runtime-8e56035bb1932e64b40d.js:1:221
    [17934] https://github.githubassets.com/assets/github-elements-6878199d7252199edf01.js:1:268
    _ https://github.githubassets.com/assets/runtime-8e56035bb1932e64b40d.js:1:221
    t< https://github.githubassets.com/assets/github-elements-6878199d7252199edf01.js:1:513
    <anonymous> https://github.githubassets.com/assets/github-elements-6878199d7252199edf01.js:1:818
    _.O https://github.githubassets.com/assets/runtime-8e56035bb1932e64b40d.js:1:621
    <anonymous> https://github.githubassets.com/assets/github-elements-6878199d7252199edf01.js:1:834
    o< https://github.githubassets.com/assets/runtime-8e56035bb1932e64b40d.js:2:248
    bound webpackJsonpCallback self-hosted:1032:17
    <anonymous> https://github.githubassets.com/assets/github-elements-6878199d7252199edf01.js:1:100
    <anonymous> https://github.githubassets.com/assets/github-elements-6878199d7252199edf01.js:1:14

07:32:40.179 SyntaxError: expected expression, got '?' 1 vendors-node_modules_lit-html_lit-html_js-af8ccc84f8e4b4d33331.js:49:2049

07:32:40.284 SyntaxError: expected expression, got '.' 1 vendors-node_modules_github_mini-throttle_dist_decorators_js-node_modules_github_catalyst_lib-098f88-ced720e3f74edec39065.js:1:7931

07:32:40.289 SyntaxError: expected expression, got '?' 1 github_command-palette_command-palette-item-element_ts-8ac31e0496c567e087b0.js:1:11539

[Zorgodon]

Seems to be broken again. https://github.com/runsisi/socat doesn't load

[SeaHOH]

You shoul try my fork, but not for SM.

[SlySven]

Can I just check - I have been running through the various recent releases and the 1.2.12 is the only one that renders some parts of the GitHub experience - but it is like wading through (setting) concrete... all the other (suffixed or not) just show this at the bottom of a PR:

whereas I was expecting:

Of course GitHub is unusable currently with PaleMoon... {and my opprobrium is entirely directed towards the first of these two. 😠 )

[SeaHOH]

It has been fixed. Also see #48 .

[Vangelis66]

https://github.com/JustOff/github-wc-polyfill/issues/50#issuecomment-1059607968

GH is broken again, just like it (was) a couple (of) weeks ago, before all the workarounds and fixes by JustOff.

got these today in network graph:

07:32:40.179 SyntaxError: expected expression, got '?' 1 vendors-node_modules_lit-html_lit-html_js-af8ccc84f8e4b4d33331.js:49:2049

07:32:40.284 SyntaxError: expected expression, got '.' 1 vendors-node_modules_github_mini-throttle_dist_decorators_js-node_modules_github_catalyst_lib-098f88-ced720e3f74edec39065.js:1:7931

07:32:40.289 SyntaxError: expected expression, got '?' 1 github_command-palette_command-palette-item-element_ts-8ac31e0496c567e087b0.js:1:11539

Back then, "they" had started toying with the optional chaining operator (?.), now that one has come back, along with "friend" nullish coalescing operator (??) :angry: :rage: :

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Nullish_coalescing_operator

(first implemented in Chrome 80/Firefox 72)

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining

(first implemented in Chrome 79/80/Firefox 74)

Unlike "methods", "operators" can't be polyfill-ed, so this is again a tough nut to crack... :disappointed:

Besides UXP-based browsers, M$, with one blow, also "decommissioned" 360EEv11 (Ch69-fork) and 360EEv12 (Ch78-fork) here, leaving me only with 360EEv13 (Ch86-fork) as the sole GH-compatible browser on my system :-1: (typing this on that one, however the GitHub comment editor is sluggish as molasses... ).

Frankly, this folly has to stop... Why, oh why, do they insist on breaking it for us "Luddites" (i.e. the ones not using latest Chrome/ChrEdge, etc.), without any provision of backwards compatibility? It isn't like GH is run by only two burned-out devs, who don't have the resources to target anything but LATEST Chromiun, is it? :angry:

[SeaHOH]

Not polyfill, but unique targeted can be replaced for them.

[Vangelis66]

It has been fixed

... I only saw this after posting my comment above, and at first I thought GitHub had taken (??) back, but it was simply wishful thinking on my part... :smile: I'll try your "fix" on Serpent later in the day, thanks :+1: , pity that 360EEv11/v12 will remain broken... Any chance this original extension gets "fixed", too?

@dirkf : Is it possible you inform your GitHub "contacts" of this latest breakage and kindly ask them to reconsider? It surely "worked" the last time... :wink:

[SeaHOH]

https://github.com/SeaHOH/github-wc-polyfill/releases/tag/1.2.15 A release, for who does not know how to pack from source.

[SeaHOH]

github-wc-polyfill-1.2.15b1 Please have a test.

[Zorgodon]

Works great. I can even get a preview of this comment!

[jrfnl]

Just installed github-wc-polyfill-1.2.15b1. Unfortunately still seeing issues with PaleMoon on Windows 10.

Example: actions workflows not showing the transript

With these errors in console:

Also couldn't post the images in this message while I was writing it, so had to switch to another browser to post this.

[SeaHOH]

@jrfnl can you refer a URL here?

[SeaHOH]

Seems we have connected to different CDNs. Or the annoying A-B test. https://github.githubassets.com/assets/workflow-run-2952a73fa18c9c1f80c9.js

[AroKol78]

https://github.com/SeaHOH/github-wc-polyfill/releases/tag/1.2.15

[SeaHOH]

Text please.

[AroKol78]

Timestamp: 2022-03-05 15:24:54
Error: SyntaxError: expected expression, got '.'
Source File: https://github.githubassets.com/assets/vendors-node_modules_github_mini-throttle_dist_decorators_js-node_modules_github_catalyst_lib-098f88-ced720e3f74edec39065.js
Line: 1, Column: 7931
Source Code:
is.title}-${this.group}-${this.subtitle}-${this.matchFields?.join("-")}`}get id(){return this._id||(this._id=(0,S.k)(thi

Timestamp: 2022-03-05 15:24:54
Error: SyntaxError: expected expression, got '?'
Source File: https://github.githubassets.com/assets/github_command-palette_command-palette-item-element_ts-8ac31e0496c567e087b0.js
Line: 1, Column: 11539
Source Code:
turn;const b={...{prefillItemStack:!1,isEmpty:!1},...p},O=t??this.providerElements;this.error=!1,await this.fetchWithSpi

[SeaHOH]

@AroKol78 I can't see this script in the releases page. Possible reason see https://github.com/JustOff/github-wc-polyfill/issues/44#issuecomment-1059773138

[SeaHOH]

The first one is GH's bug, second can be replaced by gwp.

All scripts are modified on 2 Mar, I think it's the A-B test.

[AroKol78]

I think it's the A-B test.

I think so too

https://github.com/SeaHOH/github-wc-polyfill/releases/tag/1.2.15 sometimes the page gets a different error (1.2.15b1)

Timestamp: 2022-03-05 16:00:53
Error: ReferenceError: customElements is not defined
Source File: https://github.githubassets.com/assets/element-registry-8ef117f0.js
Line: 1

Timestamp: 2022-03-05 16:00:53
Error: TypeError: window.customElements is undefined
Source File: https://github.githubassets.com/assets/chunk-index.esm-d58c91c7.js
Line: 1

Timestamp: 2022-03-05 16:00:53
Error: TypeError: window.customElements is undefined
Source File: https://github.githubassets.com/assets/chunk-index.esm-d58c91c7.js
Line: 1

Timestamp: 2022-03-05 16:00:53
Error: TypeError: window.customElements is undefined
Source File: https://github.githubassets.com/assets/chunk-index6-312d598a.js
Line: 1

Timestamp: 2022-03-05 16:00:53
Error: TypeError: window.customElements is undefined
Source File: https://github.githubassets.com/assets/chunk-frameworks-e88d5ac4.js
Line: 1

[SeaHOH]

github-wc-polyfill-1.2.15b2 Three replacements.

[dirkf]

Yes, I had non-functional comment menu last night, went away on reload, back again now:

• Edit, Hide: fail
• Copy Link, Reference in new issue, Delete: OK.

SM 2.53.11 gwp 1.2.13, customElements patched from here 23 Feb.

Surely the failing expression in # 1 just means {this.matchFields || this.matchFields.join("-")}?

What I don't understand is that this script is obviously machine-generated but it's as if the GH devs have no control over the level of the output JS, or keep changing it. Perhaps they configured the build tools to some experimental level where novel syntax just gets passed through?

Now this post is editable.

[roytam1]

github-wc-polyfill-1.2.15b2 Three replacements.

still got an error: 23:19:01.336 SyntaxError: expected expression, got '?' 1 github_command-palette_command-palette-item-element_ts-8ac31e0496c567e087b0.js:44:677

[SeaHOH]

github-wc-polyfill-1.2.15b3

[roytam1]

github-wc-polyfill-1.2.15b3

works better, but got this when I gave emoji reaction:

23:43:55.000 TypeError: this.scope is undefined 1 github_command-palette_command-palette-item-element_ts-8ac31e0496c567e087b0.js:83:12646
    hasScope https://github.githubassets.com/assets/github_command-palette_command-palette-item-element_ts-8ac31e0496c567e087b0.js:83:12646
    setDefaultSelection https://github.githubassets.com/assets/command-palette-e25efc88284f0c458d7f.js:1:8743
    updateSelectedItem https://github.githubassets.com/assets/command-palette-e25efc88284f0c458d7f.js:1:8650
    renderCurrentItems https://github.githubassets.com/assets/command-palette-e25efc88284f0c458d7f.js:1:6052
    bound renderCurrentItems self-hosted:988:17
    w/k< https://github.githubassets.com/assets/vendors-node_modules_github_mini-throttle_dist_index_js-node_modules_scroll-anchoring_dist_sc-c73d33-22da8cb2286df9aaedad.js:1:541

[AroKol78]

Timestamp: 2022-03-05 16:39:47
Error: TypeError: t is undefined
Source File: https://github.githubassets.com/assets/command-palette-e25efc88284f0c458d7f.js
Line: 1

[dirkf]

Great, patching .15b3's bootstrap.js into 1.2.13 for SM (keep patchGitHUb() instead of pfFollowUp) is a winner with SM 2.53.11. Reactions seem OK.

[SeaHOH]

23:43:55.000 TypeError: this.scope is undefined 1 github_command-palette_command-palette-item-element_ts-8ac31e0496c567e087b0.js:83:12646
  hasScope https://github.githubassets.com/assets/github_command-palette_command-palette-item-element_ts-8ac31e0496c567e087b0.js:83:12646
  setDefaultSelection https://github.githubassets.com/assets/command-palette-e25efc88284f0c458d7f.js:1:8743
  updateSelectedItem https://github.githubassets.com/assets/command-palette-e25efc88284f0c458d7f.js:1:8650
  renderCurrentItems https://github.githubassets.com/assets/command-palette-e25efc88284f0c458d7f.js:1:6052
  bound renderCurrentItems self-hosted:988:17
  w/k< https://github.githubassets.com/assets/vendors-node_modules_github_mini-throttle_dist_index_js-node_modules_scroll-anchoring_dist_sc-c73d33-22da8cb2286df9aaedad.js:1:541

Timestamp: 2022-03-05 16:39:47
Error: TypeError: t is undefined
Source File: https://github.githubassets.com/assets/command-palette-e25efc88284f0c458d7f.js
Line: 1

Out of this issue, just GH's bugs.

Great, patching .15b3's bootstrap.js into 1.2.13 for SM (keep patchGitHUb() instead of pfFollowUp) is a winner with SM 2.53.11. Reactions seem OK.

Can you provide more infomations which from console? I don't use SM, may do nothing.

[dirkf]

Can you provide more infomations which from console? I don't use SM, may do nothing.

Without patched gwp (non-functional):

16:53:26.235 TypeError: window.customElements is undefined[Learn More] index.js:250:5
...
16:53:26.264 SyntaxError: expected expression, got '?'[Learn More] vendors-node_modules_lit-html_lit-html_js-af8ccc84f8e4b4d33331.js:49:2049
...
16:53:26.690 SyntaxError: expected expression, got '.'[Learn More] vendors-node_modules_github_mini-throttle_dist_decorators_js-node_modules_github_catalyst_lib-098f88-ced720e3f74edec39065.js:1:7931

With (functional, despite the below):

16:57:22.276 Content Security Policy: The page's settings blocked the loading of a resource at self ("script-src https://github.com https://gist.github.com 'sha256-e4RJ1+xAp4xhtpaeSLNr50yP+/R80IwoR3JYjsq58MY=' 'sha256-xacOvhQ60RUi63HRCOra3xKhFWV9MCEUnuvPfqR1MvY=' 'sha256-Y97hZdvuJztaJyvPJfwpU8LImTg64KGz8oN2jC/bVMY=' 'sha256-xacOvhQ60RUi63HRCOra3xKhFWV9MCEUnuvPfqR1MvY=' https://github.githubassets.com"). Source: (function(){
if (!Element.prototype.togg.... 2945:9

16:57:24.246 SyntaxError: expected expression, got '?'[Learn More] vendors-node_modules_lit-html_lit-html_js-af8ccc84f8e4b4d33331.js:49:2049

16:57:24.576 SyntaxError: expected expression, got '.'[Learn More] vendors-node_modules_github_mini-throttle_dist_decorators_js-node_modules_github_catalyst_lib-098f88-ced720e3f74edec39065.js:1:7931

Any NoScript surrogates that might have been loaded for githubassets.com are disabled in both cases.

It looks like I needed to recompute some hash, but there don't seem to be significant effects. Even the top-right user menu is working. 'Load diff' is centered without additional styling. 'Copy the Full SHA' on a commit is still broken, though.

[jrfnl]

Thanks @SeaHOH for all your work on this! Latest version seems to work well (at least for me).

[SeaHOH]

Some functions relative to RegExp had broken/lost in SeaMonkey, I will make the polyfills later time.

[SeaHOH]

github-wc-polyfill-1.2.15b4 Fixed for last SeaMonkey.

[SeaHOH]

Script vendors-node_modules_lit-html_lit-html_js had been updated at 5 Mar 16:46, now has no ?? there, how about others?

workflow-runs
github_command-palette_command-palette-item-element_ts
vendors-node_modules_github_mini-throttle_dist_decorators_js-node_modules_github_catalyst_lib

[AroKol78]

workflow-runs
github_command-palette_command-palette-item-element_ts
vendors-node_modules_github_mini-throttle_dist_decorators_js-node_modules_github_catalyst_lib

they do not appear for me anymore

now more and more often he gets something like this on different sites

[SeaHOH]

~github-wc-polyfill-1.2.15b5~ deleted Seems GH had workaround the operator issues, relative code has been removed in b5. And fix svg rendering on camo.githubusercontent.com.

[SeaHOH]

@dirkf Are b4 and b5 working for you?

[dirkf]

b4 looking good. Clean console log. 'Copy full SHA' working!

b5 not so good:

15:10:59.177
TypeError: window.customElements is undefined index.js:250:5
15:10:59.187
ReferenceError: customElements is not defined dynamic-elements.ts:4:2

[AroKol78]

1.2.15b5

Timestamp: 2022-03-06 16:12:57
Error: ReferenceError: customElements is not defined
Source File: https://github.githubassets.com/assets/element-registry-8ef117f0.js
Line: 1
Timestamp: 2022-03-06 16:12:58
Error: TypeError: window.customElements is undefined
Source File: https://github.githubassets.com/assets/chunk-index.esm-d58c91c7.js
Line: 1
Timestamp: 2022-03-06 16:12:58
Error: TypeError: window.customElements is undefined
Source File: https://github.githubassets.com/assets/chunk-vendor-093c06f4.js
Line: 133
Timestamp: 2022-03-06 16:12:58
Error: TypeError: window.customElements is undefined
Source File: https://github.githubassets.com/assets/chunk-frameworks-e88d5ac4.js
Line: 1

and in creating a comment

Timestamp: 2022-03-06 16:13:36
Error: ReferenceError: customElements is not defined
Source File: https://github.githubassets.com/assets/element-registry-e59713c39252bd2b5dbf.js
Line: 1
Timestamp: 2022-03-06 16:13:37
Error: TypeError: window.customElements is undefined
Source File: https://github.githubassets.com/assets/behaviors-803d444aaf1b0b5d85b1.js
Line: 1
Timestamp: 2022-03-06 16:13:36
Error: TypeError: window.customElements is undefined
Source File: https://github.githubassets.com/assets/vendors-node_modules_github_clipboard-copy-element_dist_index_esm_js-node_modules_github_filt-19a0ad-b0aa79d964b0f0b0715d.js
Line: 1
Timestamp: 2022-03-06 16:13:37
Error: TypeError: window.customElements is undefined
Source File: https://github.githubassets.com/assets/vendors-node_modules_delegated-events_dist_index_js-node_modules_github_catalyst_lib_index_js-6e358f-064c9c0434d0fad1cfc8.js
Line: 1
Timestamp: 2022-03-06 16:13:37
Error: TypeError: window.customElements is undefined
Source File: https://github.githubassets.com/assets/vendors-node_modules_delegated-events_dist_index_js-node_modules_github_details-dialog-elemen-63debe-427207a86ebb1fa0f74f.js
Line: 1

[SeaHOH]

github-wc-polyfill-1.2.15b6 Sorry for typo, fixed.

[dilworks]

Yay, user menu works again on SeaMonkey!

You guys rock~

[AroKol78]

error return, many things do not work

Timestamp: 2022-03-11 19:59:45
Error: SyntaxError: expected expression, got '?'
Source File: https://github.githubassets.com/assets/8933-d8b0634d2391.js
Line: 49, Column: 2049
Source Code:
e=t)}__commitText(t){const n=this.startNode.nextSibling;t=t??"";const e=typeof t=="string"?t:String(t);n===this.endNode.
Timestamp: 2022-03-11 19:59:46
Error: SyntaxError: expected expression, got '.'
Source File: https://github.githubassets.com/assets/2403-3e07b8533bbd.js
Line: 1, Column: 7833
Source Code:
is.title}-${this.group}-${this.subtitle}-${this.matchFields?.join("-")}`}get id(){return this._id||(this._id=(0,S.k)(thi
Timestamp: 2022-03-11 19:59:46
Error: SyntaxError: expected expression, got '?'
Source File: https://github.githubassets.com/assets/7253-67d624cbaf0c.js
Line: 1, Column: 10803
Source Code:
turn;const M={...{prefillItemStack:!1,isEmpty:!1},...p},C=t??this.providerElements;this.error=!1,await this.fetchWithSpi

additional unusual csp

Timestamp: 2022-03-11 20:03:50
Warning: Content Security Policy: Couldn’t process unknown directive ‘require-trusted-types-for’
Timestamp: 2022-03-11 20:03:50
Warning: Content Security Policy: Ignoring “'unsafe-inline'” within script-src or style-src: nonce-source or hash-source specified

[Vangelis66]

I just filed #58, please add there any additional input... :cry:

(typing this is very sluggish in 360EEv13, Chromium 86 based... :disappointed: )

[garoto]

Perhaps locking this issue might be a good idea, since loading any GH issue/PR with like more than ~8 comments in Palemoon is nightmarish: the whole browser locks up for a good 5 seconds or more.