search

JustSteveKing / laravel-envoyer-sdk

A simple to use PHP class to work with the Laravel Envoyer API
MIT License
36 stars 15 forks source link

500 server error is not catched #8

Open ghost opened 3 years ago

ghost commented 3 years ago

Describe the bug At the moment their API for updating webhooks seems to be broken. When I try:

  $this
                ->envoyer
                ->hooks
                ->on($this->group->getData('envoyer.project_id'))
                ->modify($envoyerHookId, [
                    'servers' => [
                        $this->getApplicableServers($hook),
                    ],
                ]);

I get a 500 server error. But there's nothing in the code to catch any error codes like this. For me it happens here: \JustSteveKing\Laravel\Envoyer\SDK\Resources\EnvoyerResource::modify I know there is a try catch surrounding the request, but apparently an error code like 500 does not throw any errors.

JustSteveKing commented 2 years ago

That is really weird, I will add this to the list to look into