JustTemmie / steam-presence

A script that takes the game you're playing on steam and displays it on discord
MIT License
236 stars 18 forks source link

Steam store button seems to not appear, also lists wrong amount of reviews. #66

Open LunRos opened 1 month ago

LunRos commented 1 month ago

Running latest script on Win11 24H2 (Dev Build 26120.1330), Python version 3.12.3

having "ADD_STEAM_STORE_BUTTON" set to true makes it so that no button is displaying in Discord.

image

Usually button would be right under the time played, but doesn't exist anymore.

The script also seems to crash when trying to find a price for games only available through a bundle (i.e GTAV)

Setting "ADD_STEAM_STORE_BUTTON" to false seems to bypass this issue as the script maybe doesn't check for prices?

Console output: image

Another issue with this seems to be that it is displaying an amount of reviews instead of just the overall rating. image

Games steam store page reviews: image

Seems to work fine for other games (maybe its the same bundle issue mentioned)

image

Games steam store page reviews:

image

JustTemmie commented 1 month ago

unsure what exactly is going on here, i've spent the last couple weeks rewriting/restructuring the entire project on a development branch, so i haven't really been in the loop of how the current stable version of steam presence works

this honestly just seems like steam updating their API behavior or something similar, though the system wasn't really ever super stable in the first place

it should be fixed finish the fabled rewrite (whenever that is done), but for the time being there won't be a fix for this :p

JustTemmie commented 1 month ago

and yeah the finding price of items within a bundle thing is real and it's painful - fabled rewrite should fix it though

LunRos commented 1 month ago

can't wait for the rewrite, using the script 24/7 on my PC rn so if u need any testing let me know