search

JustUtahCoders / comunidades-unidas-internal

The code for comunidades unidas internal website
MIT License
10 stars 16 forks source link

Lead list scroll cuts of table header #742

Open joeldenning opened 3 years ago

joeldenning commented 3 years ago

When you go to Lead List, then click on Advanced Search, the lead table header row (ID, Last Name, Phone) properly shows:

image

However, when you scroll through the lead list, the header disappears

image

The reason is the following code:

https://github.com/JustUtahCoders/comunidades-unidas-internal/blob/b331fd9acaf3797ba5239096b27356a846cc8cd7/frontend/leads-list/table/desktop-leads-table.component.tsx#L327

The problem is that top: 45 does not have a CSS unit. It should be top: 45rem. This was a bug introduced in https://github.com/JustUtahCoders/comunidades-unidas-internal/commit/83f4fd0875736c38b0265698005550700ee1bd45 which ironically was meant to fix the same bug, but didn't do so.

joeldenning commented 3 years ago

@abbynf is going to work on this one.

nick-nack-attack commented 3 years ago

769 includes the fix