feature: eslint added and fixed a few eslint errors

JustUtahCoders / utahexpungements.org

The frontend code for utahexpungements.org

MIT License

11 stars 19 forks source link

feature: eslint added and fixed a few eslint errors #119

Closed scotttball closed 4 years ago

scotttball commented 4 years ago

Closes #117

added eslint
added joeldenning/eslint-config-react-important-stuff
fixed up .eslintrc
husky/lint-staged for frontend
added yarn lint

currently only eslint for frontend (need to configure for ejs and node to further checks for backend)

scotttball commented 4 years ago

I still need to do some manual testing on this. I've had issues with some other projects with eslint rules and hooks. I've ran into some infinite rendering issues with the props that eslint recommends to observe. Sometimes it's not always correct. I'll check it out tomorrow.

Please comment if there are any changes that should be made to this PR.

joeldenning commented 4 years ago

Just one remaining comment, then let's merge https://github.com/JustUtahCoders/utahexpungements.org/pull/119#discussion_r343513803