search

JustUtahCoders / utahexpungements.org

The frontend code for utahexpungements.org
MIT License
11 stars 19 forks source link

Olivia pdf component #148

Closed oliviaclyde closed 4 years ago

oliviaclyde commented 4 years ago

@lukeschunk for your review

I pushed changes to the pdf component file for the Proof of Service form. It is only for page 1. I will create add'l PRs for subsequent pages.

I am having trouble getting the checkmarks to only show when checked on the form. I could use a code suggestion. I couldn't get this to work: 

<PositionedCheckmark
          debugKey="documentsServedSummonsCheckmark"
          left={documentsServedCheckmarks}
          top="68.4%"
          shouldShow={data.case.summons === "Summons"}
 />
lukeschunk commented 4 years ago

@oliviaclyde i might need to dive into it more, but it looks like you're using a checkmark in the web form, so i'd expect data.case.summons to be a boolean (ie, either true or false try replacing the should show with: 

shouldShow={data.case.summons}
oliviaclyde commented 4 years ago

I have resolved the checkmark issue. Thanks @lukeschunk. I also had to modify the web form to fix two dataKeys:

dataKey="case.noticeOfURCP261"
dataKey="case.noticeOfURCP263"

I believe this PR is ready to merge master. I will open new PRs for subsequent page renderings. Take a look and see what you think.