search

JustUtahCoders / utahexpungements.org

The frontend code for utahexpungements.org
MIT License
11 stars 19 forks source link

initial work on 1st degree felony flag #160

Closed oliviaclyde closed 4 years ago

oliviaclyde commented 4 years ago

I need some help on the logic for the first degree felony flag.

oliviaclyde commented 4 years ago

I have updated the logic and used a nested "if" to check for "1st degree felony" and if true, then check for "amended".

My concern is we also need to check the disposition field on each of these flags to make sure it doesn't return "dismissed"? I believe that was a function @benschinn was writing so we could call it on each of our flags. I believe if a change is dismissed, then it doesn't count against them, right @tuckersamuelsen?

oliviaclyde commented 4 years ago

@tuckersamuelsen I can't find a docket that has a charge of "1st Degree Felony" that hasn't been amended down. I'd like to get one so I can make sure my flag returns "true" on that case.

oliviaclyde commented 4 years ago

@lukeschunk I tested this and it looked okay on several dockets I tried, but when I used the new docket Tucker uploaded that contained several 1st degree felony charges (I'll PM you the case name) it returned false when it should have returned true. I wonder if this was because of the unusal formatting on the pdf....it also had a weird format on the raw parcer too. Can you take a look?

schinns commented 4 years ago

@Mengqi89 @oliviaclyde and I looked into the issue mentioned above, and it sounds like the issue is with the parser. Tuning the parser should be addressed in a separate PR, the code here LGTM.

lukeschunk commented 4 years ago

@benschinn what is the issue with the parser? we could open an issue

schinns commented 4 years ago

@lukeschunk https://github.com/JustUtahCoders/utahexpungements.org/issues/174