JustWeiHao / pe

0 stars 0 forks source link

Person with same name are not allowed #3

Open JustWeiHao opened 2 months ago

JustWeiHao commented 2 months ago

image.png

I think that severity is Medium because it is quite common to have 2 persons that share the same name.

nus-se-bot commented 2 months ago

Team's Response

Based on the guidelines of what qualifies as a feature flaw, persons with the same name should not be allowed in the system. In the guideline it says that names with the same characters and different capitalisations should be rejected. Thus, having the same characters and same capitalisation should also be rejected by this logic. This is also made clear in our error message when you tried to add a person with a duplicate name. Below is the guideline we have followed.

image.png

Additionally, it is rare that there will be totally same full name for a person work in cafe, hence we reduce severity to low.

This situation can easily solve by appending the name with some extension such that "Janna 1" , "Janna 2" according to our implementation.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The team argued that it is rare to have persons with the same full name working in the same cafe. However, the team also suggested adding suffixes to the name to differentiate two persons of the same name. Does this mean that the name field stores the actual full name for some persons, but the "nickname" (by appending suffixes) for potential duplicate names? This results in inconsistency as well.

I think that this is a feature flaw because there is a better way to detect duplicates based on this team implementation. It is extremely rare to have persons share all their name, email, phone, and address.


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]