search

JustaPenguin / assetto-server-manager

A web interface to manage an Assetto Corsa Server.
https://github.com/JustaPenguin/assetto-server-manager/releases
MIT License
276 stars 70 forks source link

Championship parent-child schedule option error #1101

Open Valheru84 opened 2 years ago

Valheru84 commented 2 years ago

Describe the bug Setting a child session to start after a parent session has ended (via the session schedule options) results in an error but the option still seems to apply (waiting to test if the session will actually start after the parent session though). Also unable to disable option anymore via "Remove schedule", instead having to click "Schedule" to save the option being unticked, which then schedules the session for the default date and time already entered, resulting in a further step to then remove that unwanted scheduling.

These issues only started occurring after patch v2.1.3 was applied, previous to that no error occurred and the option could be disabled via "Remove schedule".

To Reproduce Error

  1. Create/edit a championship race weekend.
  2. Click "Schedule session" on a child session, tick "Start after Parent Session has completed" and then "Schedule" to apply.

Cancelling

  1. Click "Schedule session" on a child session already set to start after a parent session.
  2. Click "Remove schedule" - See that the option remains ticked after refreshing the page.
  3. Untick "Start after Parent Session has completed" and then "Schedule" to apply the change.
  4. Go back in and click "Remove schedule" to remove unwanted date and time scheduling applied as a result of step 3.

Expected behavior Enable child sessions to start when parent sessions have finished irrespective of date and time prefilled into schedule session popup and disable when needed.

Screenshots

  1. Error after configuring a session to start after parent session (happens irrespective of prefilled date and time or setting a different future date and time to try and avoid the error due to what the error itself is reporting as the issue): image

  2. The unwanted scheduling in order to save unticking the option: image

  3. Trying to enable the option while setting a later date and time (+ 3 days and 2 hours) to simply test what the error is reporting as the issue: image

  4. The resulting error: image

Desktop (please complete the following information):

Additional context I feel like something in the latest patch has broken some exception ruling where if a child session is being set to start after an already scheduled parent, to then ignore any date or time pre-filled into the fields. Even clearing these fields (so they're blank when clicking "Schedule" to save the parent option) results in the same error.

cj123 commented 2 years ago

Hi!

Thank you for this detailed report. We will look into this and sort out a fix in the next update.